Uh oh!
There was an error while loading. Please reload this page.
Doc fix: Do not mention next project in book/guessing-game - #32937
Conversation
rust-highfive
commented
Apr 13, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Manishearth
commented
Apr 13, 2016
Perhaps remove this entirely? |
deepak
commented
Apr 13, 2016
@Manishearth as a beginner, I like the old one better. It informs me that:
Just telling me that i have completed a challenge feels worse by comparison I would have liked another problem to go through. but when will that stop :-) |
Manishearth
commented
Apr 13, 2016
Yes, but it seems a bit out of place. The chapter was already concluded with the previous sentence. If this could be moved above and edited to make more sense that would be fine. |
deepak
commented
Apr 13, 2016
@Manishearth ok. fixing it |
The next project refers to the dining-philosophers problem https://github.com/rust-lang/rust/blob/27a1834ce522e3ec7fe4726b1661de16ee30c503/src/doc/book/dining-philosophers.md which was removed in rust-lang@0c6c34d so removing reference to that project from book/guessing-game
54a397e to
a40629dCompareManishearth
commented
Apr 13, 2016
@bors r+ rollup thanks! |
bors
commented
Apr 13, 2016
📌 Commit a40629d has been approved by |
…roject-in-guessing-game-doc, r=Manishearth Doc fix: Do not mention next project in book/guessing-game fixesrust-lang#32936
bors
commented
Apr 14, 2016
⌛ Testing commit a40629d with merge c7b1d45... |
bors
commented
Apr 14, 2016
💔 Test failed - auto-win-gnu-32-opt |
alexcrichton
commented
Apr 14, 2016
@bors: retry On Thu, Apr 14, 2016 at 1:02 PM, bors notifications@github.com wrote:
|
fixes#32936