Skip to content

Update E0102's example (fixes #33057) - #33058

Merged
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:fx-E0102
Apr 19, 2016
Merged

Update E0102's example (fixes #33057)#33058
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:fx-E0102

Conversation

@Manishearth

@ManishearthManishearth commented Apr 17, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@Manishearth

Manishearth commented Apr 17, 2016

Copy link
Copy Markdown
MemberAuthor

@bors delegate=GuillaumeGomez

@bors

bors commented Apr 17, 2016

Copy link
Copy Markdown
Collaborator

✌️ @GuillaumeGomez can now approve this pull request

GuillaumeGomez
GuillaumeGomez reviewed Apr 17, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/diagnostics.rs Outdated

@GuillaumeGomezGuillaumeGomezApr 17, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust flag isn't needed in this case as far as I know. If no option is passed, the code is compiled and run.

@ManishearthManishearthApr 17, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like to be explicit about this.

@GuillaumeGomezGuillaumeGomezApr 18, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep it, it'll be the only place where such a flag is used. Also, by default, it is rust code. We only precise it when it's not.

@ManishearthManishearthApr 18, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GuillaumeGomez

GuillaumeGomez commented Apr 17, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Except for the nit (not really one but I like to remain consistent with the other error codes examples), it's all good. Thanks!

@GuillaumeGomez

GuillaumeGomez commented Apr 17, 2016

Copy link
Copy Markdown
Member

Fixes #33057.

@GuillaumeGomez

GuillaumeGomez commented Apr 18, 2016

Copy link
Copy Markdown
Member

@bors: rollup

@Manishearth

Manishearth commented Apr 18, 2016

Copy link
Copy Markdown
MemberAuthor

@bors r=GuillaumeGomez rollup

@GuillaumeGomez you need to have r+ somewhere in the command

@bors

bors commented Apr 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f089cf9 has been approved by GuillaumeGomez

@bors

bors commented Apr 18, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f089cf9 with merge 7893b46...

@bors

bors commented Apr 18, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton

alexcrichton commented Apr 18, 2016

Copy link
Copy Markdown
Member

@bors: retry

On Mon, Apr 18, 2016 at 9:53 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/752

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33058 (comment)

@steveklabniksteveklabnik mentioned this pull request Apr 18, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 18, 2016
@steveklabnik
Rollup merge ofrust-lang#33058- Manishearth:fx-E0102, r=GuillaumeGomez
ec44ddc
Update E0102's example (fixesrust-lang#33057)
r? @GuillaumeGomez
bors added a commit that referenced this pull request Apr 18, 2016
@bors
Auto merge of#33081- steveklabnik:rollup, r=steveklabnik
b324fa7
Rollup of 6 pull requests
- Successful merges: #32558, #32906, #33007, #33008, #33035, #33058
- Failed merges: #32912
@bors
bors merged commit f089cf9 into rust-lang:masterApr 19, 2016
@Manishearth
Manishearth deleted the fx-E0102 branch December 2, 2016 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Manishearth@bors@GuillaumeGomez@alexcrichton