Uh oh!
There was an error while loading. Please reload this page.
resolve: Improve performance - #33064
Merged
Merged
Conversation
jseyfriedforce-pushed
the
improve_resolve_performance
branch
from
April 18, 2016 02:03
a9660f6 to
6ae8027Comparejseyfried
commented
Apr 18, 2016
ContributorAuthor
eddyb
commented
Apr 18, 2016
Contributor
@bors r+ |
bors
commented
Apr 18, 2016
Collaborator
📌 Commit 6ae8027 has been approved by |
bors
commented
Apr 18, 2016
Collaborator
⌛ Testing commit 6ae8027 with merge 63760ac... |
bors added a commit
that referenced
this pull request
Apr 18, 2016
resolve: Improve performance This fixes#33061 by speeding up searchs through all traits in scope, a bottleneck in `resolve`. According to my measurements, this PR improves resolution performance by a factor of 3.4x on `librustc`, which almost completely reverses the 3.75x performance regression reported in #33061. r? @eddyb
jseyfried
commented
Apr 18, 2016
ContributorAuthor
@eddyb thanks! The regression is currently in beta -- do you think we should beta-nominate this? |
bors
commented
Apr 18, 2016
Collaborator
nikomatsakis
commented
Apr 21, 2016
Contributor
Ordinarily we wouldn't backport a pure performance change, but approved for beta because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes#33061 by speeding up searchs through all traits in scope, a bottleneck in
resolve.According to my measurements, this PR improves resolution performance by a factor of 3.4x on
librustc, which almost completely reverses the 3.75x performance regression reported in #33061.r? @eddyb