Remove deprecated modes - #3308
Merged
Merged
Conversation
Contributor
Author
|
Just added cmp.rs to the mix. This commit may require changes to the following Servo files:
|
This commit may require changes to the following Servo files: * rust-geom/matrix.rs * servo/platform/osmain.rs * rust-layers/layers.rs * rust-geom/matrix.rs
Contributor
Author
|
Now rebased on top of incoming (340a219) and passing |
Contributor
|
Thanks! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2018
Changes: ```` fix for rustc master mem_forget: fix syntax error in code sample explicit_counter_loop fix rust-lang#3308 false positive new_ret_no_self test remove tool lints cfg flag Added new_ret_no_self exception to clippy to pass dogfood tests Removed new_ret_no_self tests from method.rs new_ret_no_self correctly lint impl return Removed unused variables new_ret_no_self fix false positive for impl trait return with associated type self new_ret_no_self corrected panic and added test stderr new_ret_no_self added positive test cases Fix some more `stutter` warnings unused unit lint Install Windows SDK 10.0 on travis cmp_owned refactor cmp_owned correct error message if rhs is deref Add a comment reminding to update README if the default changes Specify which categories are enabled by default Only run markdown linter on linux Move Travis Windows build to allowed failures Add Travis windows build Fix `doc_markdown` lints Fix `stutter` lints Fix `similar_names` warnings cmp_owned current suggestion for multiple deref cmp_owned add test for multiple dereference Corrected single-character string constant used as pattern found in dogfood test Fixes 3289, cmp_owned wording and false positive ````
bors
added a commit
that referenced
this pull request
Oct 15, 2018
submodules: update clippy from 9d33731 to 5afdf8b Should fix toolstate. Changes: ```` fix for rustc master mem_forget: fix syntax error in code sample explicit_counter_loop fix #3308 false positive new_ret_no_self test remove tool lints cfg flag Added new_ret_no_self exception to clippy to pass dogfood tests Removed new_ret_no_self tests from method.rs new_ret_no_self correctly lint impl return Removed unused variables new_ret_no_self fix false positive for impl trait return with associated type self new_ret_no_self corrected panic and added test stderr new_ret_no_self added positive test cases Fix some more `stutter` warnings unused unit lint Install Windows SDK 10.0 on travis cmp_owned refactor cmp_owned correct error message if rhs is deref Add a comment reminding to update README if the default changes Specify which categories are enabled by default Only run markdown linter on linux Move Travis Windows build to allowed failures Add Travis windows build Fix `doc_markdown` lints Fix `stutter` lints Fix `similar_names` warnings cmp_owned current suggestion for multiple deref cmp_owned add test for multiple dereference Corrected single-character string constant used as pattern found in dogfood test Fixes 3289, cmp_owned wording and false positive ````
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Prioritize single_line_fn and empty_item_single_line over brace_style
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Feb 25, 2024
Test windows random shims This adds tests for `BCryptGenRandom` and `RtlGenRandom` (aka `SystemFunction036`). Note that `BCryptGenRandom` comes in two flavours: ```rust BCryptGenRandom(null_mut(), key.as_mut_ptr(), len, BCRYPT_USE_SYSTEM_PREFERRED_RNG) BCryptGenRandom(BCRYPT_RNG_ALG_HANDLE, key.as_mut_ptr(), len, 0) ``` Fixes rust-lang#3308
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
3308: vscode: fix vscode-vim keybindings conflict r=matklad a=Veetaha Closes rust-lang#3013 I hope vscode-vim extension overrides the `type` command so that it prevents some keypresses to reach the text document editor. It conflicts with our `onEnter` keybinding that is used to support automatic doc comments extending and indentation insertion. The VSCode-native way to implement this would be to use regular expressions, but as per matklad it is considered not acceptable for the language server. Thus we implement it via a `Enter` keybinding that invokes our `onEnter` command which does it via the language-server. At the end of the day we may only apply ad hoc workarounds for conflicting extensions. But vscode has another bug for that. You either cannot use parantheses in `when` condition of a keybinding or it just malfunctions. See an issue about that here: microsoft/vscode#91473 To get the ultimate context, follow this [zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Enhanced.20typing) Co-authored-by: Veetaha <gerzoh1@gmail.com>
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
I found myself search for this, so building off of rust-lang#3013 and rust-lang#3308, I hope this note is useful.
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
10416: docs: add note about `vscode-vim` in `on_enter` r=lnicola a=7596ff I found myself search for this, so building off of rust-lang#3013 and rust-lang#3308, I hope this note is useful. Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits remove deprecated modes from cmp.rs, dbg.rs, rope.rs, and list.rs (and delete list::push).
I haven't yet managed to catchincomingwhen it was problem free, so this hasn't been all the way through amake check. Let me know whenincomingis clean...