Skip to content

Remove IPV6_V6ONLY functionality - #33124

Merged
bors merged 1 commit into
rust-lang:masterfrom
sfackler:kill-ipv6-only
Apr 24, 2016
Merged

Remove IPV6_V6ONLY functionality#33124
bors merged 1 commit into
rust-lang:masterfrom
sfackler:kill-ipv6-only

Conversation

@sfackler

@sfacklersfackler commented Apr 21, 2016

Copy link
Copy Markdown
Member

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes#33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.

@sfackler
Remove IPV6_V6ONLY functionality
c6480e8
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.
Closesrust-lang#33052
[breaking-change]
@sfacklersfackler added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api [DEPRECATED; DO NOT USE] labels Apr 21, 2016
@alexcrichton

alexcrichton commented Apr 21, 2016

Copy link
Copy Markdown
Member

cc @rust-lang/libs, thinking of merging this soon!

@alexcrichton

alexcrichton commented Apr 21, 2016

Copy link
Copy Markdown
Member

I'll also note that these methods aren't completely useless. It's possible to create a socket manually, wrap it up in TcpStream, and then later manually connect it. In that sense it can theoretically be possible for these to be useful, but I think that case would be so vanishingly rare it's not worth it.

@BurntSushi

BurntSushi commented Apr 21, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@alexcrichton Are there any cases where one would want or need to do that? (Otherwise, this sounds fine to me!)

@alexcrichton

alexcrichton commented Apr 21, 2016

Copy link
Copy Markdown
Member

Probably not, just pointing out it's not literally useless, just morally so :)

@aturon

aturon commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

This is fine by me in principle.

If we're at all concern about the breakage, we could consider landing a deprecation warning (so that people get a heads up on nightly) and then landing the removal a couple weeks later.

@sfackler

sfackler commented Apr 21, 2016

Copy link
Copy Markdown
MemberAuthor

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.

@aturon

aturon commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.

Yep. I’m fine either way.

@alexcrichton

alexcrichton commented Apr 22, 2016

Copy link
Copy Markdown
Member

@bors: r+ c6480e8

@bors

bors commented Apr 23, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c6480e8 with merge 23ccadd...

bors added a commit that referenced this pull request Apr 23, 2016
@bors
Auto merge of#33124- sfackler:kill-ipv6-only, r=alexcrichton
23ccadd
Remove IPV6_V6ONLY functionality
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.
Closes#33052
[breaking-change]
r? @alexcrichton
Will also need a backport to the beta.
@bors

bors commented Apr 24, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors
bors merged commit c6480e8 into rust-lang:masterApr 24, 2016
@sfackler
sfackler deleted the kill-ipv6-only branch April 24, 2016 00:12
@alexcrichtonalexcrichton mentioned this pull request Apr 29, 2016
Merged
@alexcrichtonalexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 29, 2016
@alexcrichton

alexcrichton commented Apr 29, 2016

Copy link
Copy Markdown
Member

Accepted for backport in #33263 (comment)

@sfacklersfackler mentioned this pull request Dec 11, 2016
Merged
sfackler added a commit to sfackler/rust that referenced this pull request Jan 6, 2017
@sfackler
Deprecate TcpListener::set_only_v6
eb5e9ab
This was supposed to have been removed in rust-lang#33124 but snuck through :(
bors added a commit that referenced this pull request Jan 6, 2017
@bors
Auto merge of#38304- sfackler:no-ipv6only, r=alexcrichton
a28701a
Deprecate TcpListener::set_only_v6
This was supposed to have been removed in #33124 but snuck through :(
Should the docs be removed?
I left the accessor undeprecated since it should actually work, though that method doesn't exist on other networking types.
r? @alexcrichton
cc @rust-lang/libs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfackler@alexcrichton@BurntSushi@aturon@bors