Uh oh!
There was an error while loading. Please reload this page.
mir: drop temps outside-in by scheduling the drops inside-out. - #33239
Merged
Conversation
rust-highfive
commented
Apr 27, 2016
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
commented
Apr 27, 2016
Contributor
@bors r+ |
bors
commented
Apr 27, 2016
Collaborator
📌 Commit d569228 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 27, 2016
mir: drop temps outside-in by scheduling the drops inside-out. It was backwards all along, but only noticeable with multiple drops in one rvalue scope. Fixesrust-lang#32433.
eddyb
commented
Apr 29, 2016
ContributorAuthor
Ahh right, I forgot to check it locally as I had two other PRs to work on. And Travis doesn't help with MIR. |
eddyb
commented
Apr 29, 2016
ContributorAuthor
@bors r- |
eddyb
commented
May 7, 2016
ContributorAuthor
I went back and checked my testcases from #32433. They're fixed, but the |
bors
commented
May 8, 2016
Collaborator
☔ The latest upstream changes (presumably #33130) made this pull request unmergeable. Please resolve the merge conflicts. |
This was referenced May 11, 2016
eddyb
commented
May 11, 2016
ContributorAuthor
@bors r=arielb1 |
bors
commented
May 11, 2016
Collaborator
📌 Commit e940de6 has been approved by |
bors
commented
May 11, 2016
Collaborator
bors added a commit
that referenced
this pull request
May 11, 2016
mir: drop temps outside-in by scheduling the drops inside-out. It was backwards all along, but only noticeable with multiple drops in one rvalue scope. Fixes#32433.
bors
commented
May 11, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was backwards all along, but only noticeable with multiple drops in one rvalue scope. Fixes#32433.