[MIR] Handle coercion casts properly when building the MIR by Aatch · Pull Request #33303 · rust-lang/rust

Aatch · 2016-05-01T06:03:27Z

Coercion casts (expr as T where the type of expr can be coerced to
T) are essentially no-ops, as the actual work is done by a coercion.
Previously a check for type equality was used to avoid emitting the
redundant cast in the MIR, but this failed for coercion casts of
function items that had lifetime parameters. The MIR trans code doesn't
handle FnPtr -> FnPtr casts and produced an error.

Also fixes a bug with type ascription expressions not having any
adjustments applied.

Fixes#33295

/cc @eddyb

Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixesrust-lang#33295

rust-highfive · 2016-05-01T06:03:34Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

arielb1 · 2016-05-01T08:28:43Z

@bors r+

bors · 2016-05-01T08:28:43Z

📌 Commit 3906aef has been approved by arielb1

bors · 2016-05-01T08:28:45Z

⌛ Testing commit 3906aef with merge 9db2745...

@eddyb

[MIR] Handle coercion casts properly when building the MIR Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixes#33295 /cc @eddyb

bors · 2016-05-01T10:07:24Z

💔 Test failed - auto-mac-64-opt-rustbuild

arielb1 · 2016-05-01T12:05:20Z

thread 'rustc' panicked at 'index out of bounds: the len is 0 but the index is 0', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librbml/leb128.rs:46
note: Run with `RUST_BACKTRACE=1` for a backtrace.

@alexcrichton
Maybe run the bots with RUST_BACKTRACE=1 set to get a better handle on this craziness?

@bors retry

bors · 2016-05-01T12:05:25Z

⚡ Previous build results for auto-mac-cross-ios-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

bors · 2016-05-01T14:12:11Z

💔 Test failed - auto-win-msvc-32-opt

arielb1 · 2016-05-01T14:14:42Z

---- [codegen-units] codegen-units\partitioning\local-inlining.rs stdout ----
error: compilation failed!
status: exit code: 101
command: PATH="C:\bot\slave\auto-win-msvc-32-opt\build\obj\i686-pc-windows-msvc/stage2/bin;C:\bot\slave\auto-win-msvc-32-opt\build\obj\i686-pc-windows-msvc\stage2\bin;C:\bot\slave\auto-win-msvc-32-opt\build\obj\i686-pc-windows-msvc\llvm\Release\lib;C:\mingw-w64\i686-4.9.1-win32-dwarf-rt_v3-rev1\mingw32\bin;C:\Python27;C:\msys64\mingw32\bin;C:\msys64\usr\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\msys64\usr\bin;C:\python27;C:\python27\scripts;C:\program files (x86)\inno setup 5;C:\program files (x86)\CMake\bin;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\110\Tools\Binn;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0" i686-pc-windows-msvc/stage2/bin/rustc.exe C:/bot/slave/auto-win-msvc-32-opt/build/src/test/codegen-units/partitioning\local-inlining.rs -L i686-pc-windows-msvc/test/codegen-units/ --target=i686-pc-windows-msvc -L i686-pc-windows-msvc/test/codegen-units/partitioning\local-inlining.stage2-i686-pc-windows-msvc.codegen-units.libaux -C prefer-dynamic -o i686-pc-windows-msvc/test/codegen-units/partitioning\local-inlining.stage2-i686-pc-windows-msvc.exe --cfg rtopt -C rpath -O -L i686-pc-windows-msvc/rt -Zprint-trans-items=lazy -Zincremental=tmp
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
error: could not load dep-graph from `tmp\dep_graph.rbml`: The system cannot find the file specified. (os error 2)
error: aborting due to previous error

What the **** - cc @nikomatsakis @michaelwoerister

@bors retry

bors · 2016-05-01T14:14:44Z

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-32-cross-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-debug-opt, auto-linux-64-opt-mir, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

bors · 2016-05-01T15:52:36Z

💔 Test failed - auto-linux-64-opt-mir

eddyb · 2016-05-01T15:55:00Z

@bors retry

bors · 2016-05-01T15:55:17Z

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-32-cross-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-64-debug-opt, auto-linux-64-opt-mir, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

bors · 2016-05-01T17:46:25Z

💔 Test failed - auto-win-msvc-64-opt-mir

alexcrichton · 2016-05-01T17:49:36Z

@bors: retry

On Sun, May 1, 2016 at 10:46 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt-mir
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/544
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#33303 (comment)

alexcrichton · 2016-05-01T17:51:51Z

Spurious because of #31657

bors · 2016-05-02T13:58:12Z

⌛ Testing commit 3906aef with merge 0eb575c...

@eddyb

[MIR] Handle coercion casts properly when building the MIR Coercion casts (`expr as T` where the type of `expr` can be coerced to `T`) are essentially no-ops, as the actual work is done by a coercion. Previously a check for type equality was used to avoid emitting the redundant cast in the MIR, but this failed for coercion casts of function items that had lifetime parameters. The MIR trans code doesn't handle `FnPtr -> FnPtr` casts and produced an error. Also fixes a bug with type ascription expressions not having any adjustments applied. Fixes#33295 /cc @eddyb

bors · 2016-05-02T16:09:10Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned arielb1 May 1, 2016

Aatch changed the title ~~Handle coercion casts properly when building the MIR~~[MIR] Handle coercion casts properly when building the MIRMay 1, 2016

bors merged commit 3906aef into rust-lang:masterMay 2, 2016

This was referenced May 2, 2016
Implement constant support in MIR. #33130
Merged
Prepare ConstVal for constant propagators and reduce eval_const_expr in MIR #33274
Closed

oli-obk mentioned this pull request Sep 6, 2017
Meta issue for FIXMEs that reference closed issues #44366
Open

Uh oh!

Uh oh!

Conversation

Aatch commented May 1, 2016

Uh oh!

rust-highfive commented May 1, 2016

Uh oh!

arielb1 commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

arielb1 commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

arielb1 commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

eddyb commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

bors commented May 1, 2016

Uh oh!

alexcrichton commented May 1, 2016

Uh oh!

alexcrichton commented May 1, 2016

Uh oh!

bors commented May 2, 2016

Uh oh!

bors commented May 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants