typeck: when suggesting associated fns, do not show call site as fallback

[birkenfeld]

In case we cannot produce a span for the location of the definition, just do not show a span at all.

cc: #29121

[rust-highfive]

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

[Manishearth]

This does not fix #29121, that bug is about improving the diagnostics to help in both situations (when an impl is wrong and when a call is wrong)

[birkenfeld]

True, should only reference the issue.

[Manishearth]

Can we use span_if_local instead with if let? r=me with that nit fixed

[birkenfeld]

@Manishearth like that?

[Manishearth]

@bors r+

yep!

[bors]

📌 Commit 832ce20 has been approved by Manishearth

[nrc]

style nit: newline before closing brace

[birkenfeld]

@nrc@Manishearth since this is already rollup-ed, what's the procedure to fix it?

[nrc]

@birkenfeld a follow-up PR is probably best, if you're quick, @Manishearth might be able to get it into the rollup - these things often take a few goes to land.

[Manishearth]

Just fix up this PR and I'll re-rollup. I have scripts for efficiently dealing with rollups

[birkenfeld]

@Manishearth added a followup commit here.

[Manishearth]

@bors r+

[bors]

📌 Commit b7821f9 has been approved by Manishearth

[Manishearth]

/buildslave/rust-buildbot/slave/auto-linux-64-cross-armhf/build/src/librustc_typeck/check/method/suggest.rs:267:29: 267:42 error: no method named `fileline_note` found for type `&mut syntax::errors::DiagnosticBuilder<'_>` in the current scope
/buildslave/rust-buildbot/slave/auto-linux-64-cross-armhf/build/src/librustc_typeck/check/method/suggest.rs:267 err.fileline_note(span, &note_str);
^~~~~~~~~~~~~
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
error: Could not compile `rustc_typeck`.

[Manishearth]

@bors r- delegate+

[bors]

✌️ @birkenfeld can now approve this pull request

[birkenfeld]

@Manishearth wait, what? Why is this method missing? It is definitely not missing here (and compiles for me).

[Manishearth]

Oh, it probably got changed in the rollup, Niko's error message overhaul might have tweaked things. Rebase and try building again?

[birkenfeld]

@bors r=Manishearth

[bors]

📌 Commit 780f725 has been approved by Manishearth

[bors]

⌛ Testing commit 780f725 with merge 3157691...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild