typeck: limit number of candidates shown for a single error by birkenfeld · Pull Request #33338 · rust-lang/rust

birkenfeld · 2016-05-02T08:46:33Z

No idea if 10/11 is a good limit. Are there any other such limits in rustc currently?

Fixes: #25356

rust-highfive · 2016-05-02T08:46:48Z

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

Manishearth · 2016-05-02T19:11:16Z

Manishearth · 2016-05-02T19:12:14Z

LGTM. I'd like someone else (@jonathandturner?) to rubber-stamp the number 10 as well, though 😄

sophiajt · 2016-05-02T19:40:50Z

How difficult would it be to show an elision?

Something like:

src\main.rs:206:9: 206:35 error: multiple applicable methods in scope [E0034]
src\main.rs:206 0.0.max(normal.dot(light_dir)) * res
^~~~~~~~~~~~~~~~~~~~~~~~~~
src\main.rs:206:9: 206:35 note: candidate #1 is defined in an impl of the trait `core::iter::Iterator` for the type `std::ascii::EscapeDefault`
src\main.rs:206 0.0.max(normal.dot(light_dir)) * res
^~~~~~~~~~~~~~~~~~~~~~~~~~
src\main.rs:206:9: 206:35 note: candidate #2 is defined in an impl of the trait `core::iter::Iterator` for the type `std::collections::hash::table::RawBuckets<'_, _, _>`
src\main.rs:206 0.0.max(normal.dot(light_dir)) * res
^~~~~~~~~~~~~~~~~~~~~~~~~~
src\main.rs:206:9: 206:35 note: additional candidates elided.

FWIW, I'm fine stopping at 10, but I think it'd be good to let the user know there were others, they just aren't shown.

birkenfeld · 2016-05-02T19:44:10Z

@jonathandturner it should already say "N more candidates not shown" at the end.

I just found another example in

rust/src/librustc/traits/error_reporting.rs

Line 209 in 90318b8

fnreport_similar_impl_candidates(span:Span,

- it stops at 4 and says "and N others" at the end. I could adapt to this.

sophiajt · 2016-05-02T19:46:10Z

Great, I missed that. If it has the message, I'm fine stopping even sooner than 10. 4 sounds good.

Manishearth · 2016-05-02T19:46:49Z

sgtm either way. I'd like to switch to "and N others" though, let's keep things uniform.

@bors delegate+

bors · 2016-05-02T19:46:50Z

✌️ @birkenfeld can now approve this pull request

birkenfeld · 2016-05-03T04:51:15Z

@bors r=Manishearth

bors · 2016-05-03T04:51:16Z

📌 Commit 9508180 has been approved by Manishearth

bors · 2016-05-03T13:52:24Z

⌛ Testing commit 9508180 with merge db2531f...

Manishearth · 2016-05-03T13:54:53Z

@bors clean force

Manishearth · 2016-05-03T13:55:25Z

@bors r- clean force

(something's wrong with the queue)

Manishearth · 2016-05-03T13:55:50Z

@bors r+ clean

bors · 2016-05-03T13:55:51Z

📌 Commit 9508180 has been approved by Manishearth

alexcrichton · 2016-05-03T16:25:13Z

@bors: retry force clean

Rollup of 14 pull requests - Successful merges: #33277, #33294, #33314, #33322, #33333, #33338, #33339, #33340, #33343, #33357, #33363, #33365, #33371, #33372 - Failed merges:

steveklabnik · 2016-05-03T20:37:00Z

Is the travis failure here legitimate?

birkenfeld · 2016-05-03T20:51:37Z

Yes; the diagnostics API changed on master. I'll fix it soon.

Rollup of 14 pull requests - Successful merges: #33277, #33294, #33314, #33322, #33333, #33338, #33339, #33340, #33343, #33357, #33363, #33365, #33371, #33372 - Failed merges:

bors · 2016-05-11T10:00:47Z

☔ The latest upstream changes (presumably #33425) made this pull request unmergeable. Please resolve the merge conflicts.

Limit of 4 taken consistent with limit for "similar impl candidates" in rustc::traits::error_reporting. Fixes: rust-lang#25356

birkenfeld · 2016-05-12T05:56:57Z

Rebased.

jseyfried · 2016-05-12T08:50:18Z

@bors r+

bors · 2016-05-12T08:50:19Z

📌 Commit 6ab93d7 has been approved by jseyfried

bors · 2016-05-12T11:01:56Z

⌛ Testing commit 6ab93d7 with merge e88defe...

typeck: limit number of candidates shown for a single error No idea if 10/11 is a good limit. Are there any other such limits in rustc currently? Fixes: #25356

bors · 2016-05-12T13:26:55Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned Aatch May 2, 2016

Manishearth reviewed May 2, 2016
View reviewed changes

birkenfeld force-pushed the issue-25356 branch from 03ff5a6 to 9508180Compare May 2, 2016 19:53

Manishearth mentioned this pull request May 3, 2016
Rollup of 14 pull requests #33376
Merged

Manishearth closed this May 3, 2016

Manishearth reopened this May 3, 2016

Manishearth closed this May 3, 2016

Manishearth reopened this May 3, 2016

Manishearth closed this May 3, 2016

Manishearth reopened this May 3, 2016

Manishearth closed this May 3, 2016

Manishearth reopened this May 3, 2016

birkenfeld force-pushed the issue-25356 branch from 9508180 to a05bd5bCompare May 4, 2016 05:12

typeck: limit number of candidates shown for a single error
6ab93d7
Limit of 4 taken consistent with limit for "similar impl candidates" in rustc::traits::error_reporting. Fixes: rust-lang#25356

birkenfeld force-pushed the issue-25356 branch from a05bd5b to 6ab93d7Compare May 12, 2016 05:55

bors added a commit that referenced this pull request May 12, 2016
Auto merge of#33338- birkenfeld:issue-25356, r=jseyfried
e88defe
typeck: limit number of candidates shown for a single error No idea if 10/11 is a good limit. Are there any other such limits in rustc currently? Fixes: #25356

bors merged commit 6ab93d7 into rust-lang:masterMay 12, 2016

birkenfeld deleted the issue-25356 branch May 12, 2016 17:36

bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 13, 2016

Uh oh!

Uh oh!

Conversation

birkenfeld commented May 2, 2016

Uh oh!

rust-highfive commented May 2, 2016

Uh oh!

ManishearthMay 2, 2016

Choose a reason for hiding this comment

Uh oh!

ManishearthMay 2, 2016

Choose a reason for hiding this comment

Uh oh!

Manishearth commented May 2, 2016

Uh oh!

sophiajt commented May 2, 2016

Uh oh!

birkenfeld commented May 2, 2016

Uh oh!

sophiajt commented May 2, 2016

Uh oh!

Manishearth commented May 2, 2016

Uh oh!

bors commented May 2, 2016

Uh oh!

birkenfeld commented May 3, 2016

Uh oh!

bors commented May 3, 2016

Uh oh!

bors commented May 3, 2016

Uh oh!

Manishearth commented May 3, 2016

Uh oh!

Manishearth commented May 3, 2016

Uh oh!

Manishearth commented May 3, 2016

Uh oh!

bors commented May 3, 2016

Uh oh!

alexcrichton commented May 3, 2016

Uh oh!

steveklabnik commented May 3, 2016

Uh oh!

birkenfeld commented May 3, 2016

Uh oh!

bors commented May 11, 2016

Uh oh!

birkenfeld commented May 12, 2016

Uh oh!

jseyfried commented May 12, 2016

Uh oh!

bors commented May 12, 2016

Uh oh!

bors commented May 12, 2016

Uh oh!

bors commented May 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants