Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Document many more parts of the build - #33360
Merged
Merged
Conversation
rust-highfive
commented
May 2, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 2, 2016
MemberAuthor
I'm also more than willing to add any other documentation for rustbuild, so if anything is unclear or not documented well, please let me know! |
Contributor
There was a problem hiding this comment.
this fixme is just no longer relevant/
MemberAuthor
There was a problem hiding this comment.
Ah yeah this is just gonna stick around until the makefiles go away, so no need to keep the FIXME
brson
commented
May 3, 2016
Contributor
r=me |
This commit expands the bootstrap build system's `README.md` as well as ensuring that all API documentation is present and up-to-date. Additionally a new `config.toml.example` file is checked in with commented out versions of all possible configuration values.
alexcrichton
commented
May 3, 2016
MemberAuthor
@bors: r=brson f72bf36 |
bors
commented
May 3, 2016
Collaborator
🙀 |
alexcrichton
commented
May 3, 2016
MemberAuthor
bors
commented
May 8, 2016
Collaborator
⌛ Testing commit f72bfe6 with merge ed3b03c... |
bors
commented
May 8, 2016
Collaborator
💔 Test failed - auto-linux-64-opt-rustbuild |
alexcrichton
commented
May 8, 2016
MemberAuthor
bors
commented
May 9, 2016
Collaborator
⌛ Testing commit f72bfe6 with merge 27edda2... |
bors added a commit
that referenced
this pull request
May 9, 2016
rustbuild: Document many more parts of the build This commit expands the bootstrap build system's `README.md` as well as ensuring that all API documentation is present and up-to-date. Additionally a new `config.toml.example` file is checked in with commented out versions of all possible configuration values.
bors
commented
May 9, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the bootstrap build system's
README.mdas well as ensuringthat all API documentation is present and up-to-date. Additionally a new
config.toml.examplefile is checked in with commented out versions of allpossible configuration values.