Uh oh!
There was an error while loading. Please reload this page.
rustdoc: display field types together with names in detailed docs - #33377
rustdoc: display field types together with names in detailed docs#33377birkenfeld wants to merge 1 commit into
Conversation
rust-highfive
commented
May 3, 2016
r? @cmr (rust_highfive has picked a reviewer for you, use r? to override) |
emberian
commented
May 3, 2016
I think I'm in favor. |
steveklabnik
commented
May 3, 2016
Can you show a screenshot of what this looks like? |
birkenfeld
commented
May 3, 2016
GuillaumeGomez
commented
May 3, 2016
Nice but I'm afraid it's a bit too loaded. Hard choice... |
emberian
commented
May 4, 2016
To render this nicely, I think the field name and type should be on its own line, with the documentation for it following indented a bit. |
emberian
commented
May 4, 2016
(And I think the |
birkenfeld
commented
May 5, 2016
If no one beats me to it, I'll change this to implement @cmr's suggestions. |
birkenfeld
commented
May 9, 2016
GuillaumeGomez
commented
May 9, 2016
I really don't like this design. :-/ Maybe with the "[-]" thing, it would work better at first. But I don't know how we could display the field's information nicely... |
TyOverby
commented
May 16, 2016
Big 👍 for me! I always felt dumb having to scroll up to check field types. |
bors
commented
May 30, 2016
☔ The latest upstream changes (presumably #33965) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
Jul 19, 2016
Closing due to inactivity, but feel free to reopen with a rebase! |




Is this desirable? The problem I can see is that the type names might get quite long.
Fixes: #32024