Uh oh!
There was an error while loading. Please reload this page.
rustc: Change target_env for ARM targets to gnu - #33403
Merged
Merged
Conversation
Right now they're `gnueabihf` and `gnueabi`, but when adding new platforms like musl on ARM it's unfortunate to have to test for all three (`musl`, `musleabi`, and `musleabihf`). This PR switches everything currently to `gnu`, and the new musl targets can also use `musl` when they land. Closesrust-lang#33244
rust-highfive
commented
May 4, 2016
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 4, 2016
MemberAuthor
r? @brson |
brson
commented
May 4, 2016
Contributor
Is there anywhere our |
alexcrichton
commented
May 4, 2016
MemberAuthor
Unfortunately not that I know of, no |
brson
commented
May 4, 2016
Contributor
@bors r+ |
bors
commented
May 4, 2016
Collaborator
📌 Commit 29875c2 has been approved by |
TimNN
commented
May 5, 2016
Contributor
I think theres some documentation in the reference? |
brson
commented
May 5, 2016
Contributor
@TimNN Thanks for the pointer. I'll send a followup patch. |
brson added a commit
to brson/rust
that referenced
this pull request
May 5, 2016
The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 5, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 6, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 7, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 7, 2016
doc: Update reference with better description of target_env The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
bors
commented
May 8, 2016
Collaborator
bors added a commit
that referenced
this pull request
May 8, 2016
rustc: Change target_env for ARM targets to `gnu` Right now they're `gnueabihf` and `gnueabi`, but when adding new platforms like musl on ARM it's unfortunate to have to test for all three (`musl`, `musleabi`, and `musleabihf`). This PR switches everything currently to `gnu`, and the new musl targets can also use `musl` when they land. Closes#33244
bors
commented
May 8, 2016
Collaborator
dlrobertson pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
The definition of this value recently changed slightly. It no longer corresponds directly to the target triple. Also shuffled things around to make the order of cfg descriptions more logical and added text related them to the target triple. cc rust-lang#33403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now they're
gnueabihfandgnueabi, but when adding new platforms likemusl on ARM it's unfortunate to have to test for all three (
musl,musleabi,and
musleabihf). This PR switches everything currently tognu, and the newmusl targets can also use
muslwhen they land.Closes#33244