Uh oh!
There was an error while loading. Please reload this page.
Fix several -Z orbit crater blockers. - #33488
Merged
Merged
Conversation
rust-highfive
commented
May 7, 2016
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
May 9, 2016
ContributorAuthor
@nikomatsakis Could you try crater + |
nikomatsakis
commented
May 9, 2016
Contributor
@eddyb done. |
Aatch
commented
May 10, 2016
Contributor
@bors r+ |
bors
commented
May 10, 2016
Collaborator
📌 Commit cb3a557 has been approved by |
eddyb
commented
May 10, 2016
ContributorAuthor
Crater results, in case anyone cares. The only regression is just a (timeout) false positive. |
bors
commented
May 10, 2016
Collaborator
bors added a commit
that referenced
this pull request
May 10, 2016
Fix several -Z orbit crater blockers. Fixes 3 of the issues found by @nikomatsakis' crater run with `-Z orbit` forced on: https://gist.github.com/nikomatsakis/6688c30a0e5d3fed07cc1ebd4efb1412 Two of the regressions seemed to be fixed by #33130 and the remaining two are timeouts.
bors
commented
May 10, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3 of the issues found by @nikomatsakis' crater run with
-Z orbitforced on:https://gist.github.com/nikomatsakis/6688c30a0e5d3fed07cc1ebd4efb1412
Two of the regressions seemed to be fixed by #33130 and the remaining two are timeouts.