Skip to content

Improve help for make command - #33489

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:howto
May 12, 2016
Merged

Improve help for make command#33489
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:howto

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented May 7, 2016

Copy link
Copy Markdown
Member

@hanna-kruppe

hanna-kruppe commented May 7, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Some similar information is in CONTRIBUTING.md in the "Useful targets" section. Perhaps these targets should be added there?

@GuillaumeGomez

GuillaumeGomez commented May 7, 2016

Copy link
Copy Markdown
MemberAuthor

I think the makefile's readme should be on its own. However the point here is just to open the debate. :)

@alexcrichton

alexcrichton commented May 8, 2016

Copy link
Copy Markdown
Member

Could this be merged in perhaps some other documentation? It'd be kinda unfortunate to have another top-level file dedicated to a system that's being phased out.

@GuillaumeGomez

GuillaumeGomez commented May 8, 2016

Copy link
Copy Markdown
MemberAuthor

@alexcrichton: Absolutely, where would you want to add it? Any file in mind? The one @rkruppe proposed doesn't seem to be a very good fit.

@alexcrichton

alexcrichton commented May 9, 2016

Copy link
Copy Markdown
Member

I believe we already have the header of Makefile.in, make help, and make tips lying around.

@steveklabnik

steveklabnik commented May 10, 2016

Copy link
Copy Markdown
Contributor

r? @alexcrichton

Since you care about where this is located, I'll let you take this one 😄

@GuillaumeGomez

GuillaumeGomez commented May 10, 2016

Copy link
Copy Markdown
MemberAuthor

Updated. So I extended make help and added a help message if you enter an invalid make rule.

@GuillaumeGomezGuillaumeGomez changed the title Add beginning of a "HOWTO" for make commandsImprove help for make commandMay 10, 2016
alexcrichton
alexcrichton reviewed May 10, 2016
View reviewed changes
Comment threadMakefile.in Outdated

@alexcrichtonalexcrichtonMay 10, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break a bare make?

@GuillaumeGomezGuillaumeGomezMay 10, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts as expected.

@alexcrichtonalexcrichtonMay 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this end up doing? Is this just to translate make foo into a help message here?

@GuillaumeGomezGuillaumeGomezMay 11, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, more than this. If you enter an invalid rules, this rule will be called.

@GuillaumeGomez

GuillaumeGomez commented May 10, 2016

Copy link
Copy Markdown
MemberAuthor

Updated.

@alexcrichton

alexcrichton commented May 11, 2016

Copy link
Copy Markdown
Member

@bors: r+ 0619eeb

@alexcrichton

alexcrichton commented May 11, 2016

Copy link
Copy Markdown
Member

@bors: rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 11, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33489- GuillaumeGomez:howto, r=alexcrichton
3bb96ab
Improve help for make command
r? @steveklabnik
@GuillaumeGomezGuillaumeGomez mentioned this pull request May 11, 2016
Merged
bors added a commit that referenced this pull request May 11, 2016
@bors
Auto merge of#33562- GuillaumeGomez:rollup, r=steveklabnik
22ac88f
Rollup of 3 pull requests
- Successful merges: #33401, #33489, #33558
- Failed merges: #33342, #33475, #33517
@bors
bors merged commit 0619eeb into rust-lang:masterMay 12, 2016
@GuillaumeGomez
GuillaumeGomez deleted the howto branch November 24, 2017 20:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@hanna-kruppe@alexcrichton@steveklabnik@bors