Skip to content

Inline RawVec::cap - #33522

Merged
bors merged 1 commit into
rust-lang:masterfrom
mbrubeck:inline-rawvec-cap
May 11, 2016
Merged

Inline RawVec::cap#33522
bors merged 1 commit into
rust-lang:masterfrom
mbrubeck:inline-rawvec-cap

Conversation

@mbrubeck

@mbrubeckmbrubeck commented May 9, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

This was showing up in a Servo profile.

@mbrubeck
mbrubeckforce-pushed the inline-rawvec-cap branch from 3144064 to 06f5fa4CompareMay 9, 2016 18:45
@mbrubeck

mbrubeck commented May 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Per discussion on #33357, this function is generic and therefore already inlineable. It was probably not inlined because Servo's build system sets codegen-units > 1 by default. Due to #32469 this can inhibit inlining of functions that are generic but not #[inline].

@nagisa

nagisa commented May 9, 2016

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 9, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 06f5fa4 has been approved by nagisa

@pcwaltonpcwalton mentioned this pull request May 9, 2016
Closed
@eddyb

eddyb commented May 11, 2016

Copy link
Copy Markdown
Contributor

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 11, 2016
@steveklabnik
Rollup merge ofrust-lang#33522- mbrubeck:inline-rawvec-cap, r=nagisa
30df9d0
Inline RawVec::cap
This was showing up in a Servo profile.
@steveklabniksteveklabnik mentioned this pull request May 11, 2016
Merged
bors added a commit that referenced this pull request May 11, 2016
@bors
Auto merge of#33556- steveklabnik:rollup, r=steveklabnik
e37f859
Rollup of 9 pull requests
- Successful merges: #33129, #33260, #33345, #33386, #33522, #33524, #33528, #33539, #33542
- Failed merges: #33342, #33475, #33517
@bors
bors merged commit 06f5fa4 into rust-lang:masterMay 11, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbrubeck@nagisa@bors@eddyb