Skip to content

Reword the short diagnostic for E0509 - #33676

Merged
bors merged 1 commit into
rust-lang:masterfrom
hanna-kruppe:e0509-exact-words
May 21, 2016
Merged

Reword the short diagnostic for E0509#33676
bors merged 1 commit into
rust-lang:masterfrom
hanna-kruppe:e0509-exact-words

Conversation

@hanna-kruppe

@hanna-kruppehanna-kruppe commented May 16, 2016

Copy link
Copy Markdown
Contributor

Saying that a type implements a trait is much more idiomatic than saying it defines the trait.

@rust-highfive

rust-highfive commented May 16, 2016

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@sanxiyn

sanxiyn commented May 17, 2016

Copy link
Copy Markdown
Contributor

This needs to update the test suite. (Tests will fail otherwise.)

@GuillaumeGomez

GuillaumeGomez commented May 17, 2016

Copy link
Copy Markdown
Member

I agree. Big 👍!

This needs to update the test suite. (Tests will fail otherwise.)

True.

@hanna-kruppe

hanna-kruppe commented May 17, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

D'oh! Can you tell it's my first time touching diagnostics? 😄

I think I updated all tests now (local build/tests not finished yet).

@hanna-kruppe

hanna-kruppe commented May 17, 2016

Copy link
Copy Markdown
ContributorAuthor

Travis is taking its sweet time with the build, but at least stage2-cfail passes locally.

@sanxiyn

sanxiyn commented May 18, 2016

Copy link
Copy Markdown
Contributor

Failed tidy. :(

@hanna-kruppe

hanna-kruppe commented May 18, 2016

Copy link
Copy Markdown
ContributorAuthor

Ugh. Fixed now.

@sanxiyn

sanxiyn commented May 18, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ac6da22 has been approved by sanxiyn

@bors

bors commented May 19, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #33688) made this pull request unmergeable. Please resolve the merge conflicts.

Robin Kruppe
Reword the short diagnostic for E0509
e575d19
Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
@hanna-kruppe

hanna-kruppe commented May 19, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased

@sanxiyn

sanxiyn commented May 20, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 20, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit e575d19 has been approved by sanxiyn

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 20, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33676- rkruppe:e0509-exact-words, r=sanxiyn
f22c5aa
Reword the short diagnostic for E0509
Saying that a type *implements* a trait is much more idiomatic than saying it *defines* the trait.
@GuillaumeGomezGuillaumeGomez mentioned this pull request May 20, 2016
Merged
bors added a commit that referenced this pull request May 20, 2016
@bors
Auto merge of#33758- GuillaumeGomez:rollup, r=Manishearth
500e5c1
Rollup of 6 pull requests
- Successful merges: #33668, #33676, #33683, #33734, #33739, #33745
- Failed merges: #33578
@bors
bors merged commit e575d19 into rust-lang:masterMay 21, 2016
@hanna-kruppe
hanna-kruppe deleted the e0509-exact-words branch February 2, 2026 22:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hanna-kruppe@rust-highfive@sanxiyn@GuillaumeGomez@bors@arielb1