Skip to content

implement fuzzy matching in on_unimplemented - #33694

Merged
bors merged 2 commits into
rust-lang:masterfrom
arielb1:fuzzy-on-unimplemented
May 19, 2016
Merged

implement fuzzy matching in on_unimplemented#33694
bors merged 2 commits into
rust-lang:masterfrom
arielb1:fuzzy-on-unimplemented

Conversation

@arielb1

@arielb1arielb1 commented May 17, 2016

Copy link
Copy Markdown
Contributor

bluss
bluss reviewed May 18, 2016
View reviewed changes
Comment threadsrc/libcore/slice.rs Outdated

@blussblussMay 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure the message is as clear as possible to the users that will be helped, maybe we can change to “slice index type must be usize”? I just think the “usizes” formulation will be confusing.

@nikomatsakis

nikomatsakis commented May 18, 2016

Copy link
Copy Markdown
Contributor

cc @GuillaumeGomez

nikomatsakis
nikomatsakis reviewed May 18, 2016
View reviewed changes
Comment threadsrc/librustc/traits/error_reporting.rs Outdated

@nikomatsakisnikomatsakisMay 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: incomplete sentence... "infer and error are fuzzy equal to all types", I guess?

@nikomatsakisnikomatsakisMay 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: incomplete sentence... "infer and error are fuzzy equal to all types", I guess?

@nikomatsakis

nikomatsakis commented May 18, 2016

Copy link
Copy Markdown
Contributor

Looks great!

r=me after nits and once we settle on a good wording for the error message :)

@arielb1
arielb1force-pushed the fuzzy-on-unimplemented branch from 363ff9c to b344c71CompareMay 18, 2016 16:13
@arielb1

arielb1 commented May 18, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

<updated>

nikomatsakis
nikomatsakis reviewed May 18, 2016
View reviewed changes
Comment threadsrc/libcore/slice.rs Outdated
#[stable(feature = "rust1", since = "1.0.0")]
#[allow(unused_attributes)]
#[rustc_on_unimplemented = "a usize is required to index into a slice"]
#[rustc_on_unimplemented = "slice indices are of type usize"]

@nikomatsakisnikomatsakisMay 18, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: usize

@arielb1

arielb1 commented May 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented May 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b344c71 has been approved by nikomatsakis

@nikomatsakis

nikomatsakis commented May 18, 2016

Copy link
Copy Markdown
Contributor

r=me modulo nit

@arielb1

arielb1 commented May 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=nikomatsakis

@bors

bors commented May 18, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b9a201c has been approved by nikomatsakis

@bors

bors commented May 19, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b9a201c with merge d0ca0ca...

bors added a commit that referenced this pull request May 19, 2016
@bors
Auto merge of#33694- arielb1:fuzzy-on-unimplemented, r=nikomatsakis
d0ca0ca
implement fuzzy matching in on_unimplemented
Fixes#31062
r? @nikomatsakis
@bors

bors commented May 19, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors
bors merged commit b9a201c into rust-lang:masterMay 19, 2016
@borsbors mentioned this pull request May 19, 2016
Merged
@blussbluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 19, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

relnotesMarks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arielb1@nikomatsakis@bors@bluss