Uh oh!
There was an error while loading. Please reload this page.
Cleanup macro expansion and improve diagnostics - #33766
Merged
Merged
Conversation
…he post-expansion visitor
nrc
commented
May 23, 2016
Member
Damn, @jseyfied, you've been busy :-) |
| &fld.cx.parse_sess.codemap(), | ||
| &fld.cx.ecfg.features.unwrap()); | ||
| } | ||
| trait MacroGenerable: Sized { |
Member
There was a problem hiding this comment.
Could you comment on what this trait is for, what should implement it, etc.
nrc
commented
May 23, 2016
Member
r+ with the extra comment |
jseyfried
commented
May 24, 2016
ContributorAuthor
@nrc I added some comments. |
nrc
commented
May 26, 2016
Member
@bors: r+ |
bors
commented
May 26, 2016
Collaborator
📌 Commit e9c0283 has been approved by |
bors
commented
May 26, 2016
Collaborator
⌛ Testing commit e9c0283 with merge dc91467... |
bors
commented
May 26, 2016
Collaborator
This was referenced May 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup macro expansion and improve diagnostics. Fixes#33709.
r? @nrc