Uh oh!
There was an error while loading. Please reload this page.
Makefile.in: dont use unnecessary escapes in echo - #33786
Merged
Conversation
GuillaumeGomez
commented
May 22, 2016
Member
Simple and efficient. I like it! 😄 Thanks a lot! @bors: r+ rollup |
Member
Oh right, I forgot... |
jseyfried
commented
Jun 4, 2016
Contributor
@bors r+ rollup |
bors
commented
Jun 4, 2016
Collaborator
📌 Commit d5c7ddc has been approved by |
bors
commented
Jun 5, 2016
Collaborator
⌛ Testing commit d5c7ddc with merge c641b4c... |
bors
commented
Jun 5, 2016
Collaborator
⛄ The build was interrupted to prioritize another pull request. |
bors
commented
Jun 6, 2016
Collaborator
bors added a commit
that referenced
this pull request
Jun 6, 2016
Makefile.in: dont use unnecessary escapes in echo I don't know if `echo` allows escapes without `-e` on other systems, but on a GNU userland this outputs literal `\n` on the terminal. In this case there's an easy way to write this without escapes anyway. r? @GuillaumeGomez
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Jun 6, 2016
Makefile.in: dont use unnecessary escapes in echo I don't know if `echo` allows escapes without `-e` on other systems, but on a GNU userland this outputs literal `\n` on the terminal. In this case there's an easy way to write this without escapes anyway. r? @GuillaumeGomez
bors
commented
Jun 6, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if
echoallows escapes without-eon other systems, but on a GNU userland this outputs literal\non the terminal. In this case there's an easy way to write this without escapes anyway.r? @GuillaumeGomez