Uh oh!
There was an error while loading. Please reload this page.
stable features lint warning mentions version stabilized - #33973
Conversation
To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. This is in the matter of issue rust-lang#33394.
rust-highfive
commented
May 30, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I slightly edited your issue to read "Fixes #33394", so Github will close the relevant issue automatically. |
brson
commented
May 31, 2016
@bors r+ |
bors
commented
May 31, 2016
📌 Commit 06c9e0f has been approved by |
bors
commented
May 31, 2016
⌛ Testing commit 06c9e0f with merge 8bb86da... |
bors
commented
May 31, 2016
💔 Test failed - auto-linux-64-opt-rustbuild |
alexcrichton
commented
May 31, 2016
@bors: retry On Tue, May 31, 2016 at 3:50 PM, bors notifications@github.com wrote:
|
…notes_version_stabilized, r=brson stable features lint warning mentions version stabilized To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. Fixesrust-lang#33394.  r? @brson (tagging Brian because he [wrote](rust-lang#21958) the lint)
To accomplish this, we alter the checks in
rustc::middle::stabilitytouse the
StabilityLeveldefined insyntax::attr(which includes theversion in which the feature was stabilized) rather than the local
StabilityLevelin the same module, and make thedeclared_stable_lang_featuresfield ofsyntax::feature_gate::Featureshold a Vec of feature-name, spantuples (in analogy to the
declared_lib_featuresfield) rather thanjust spans.
Fixes#33394.
r? @brson (tagging Brian because he wrote the lint)