rustdoc: Don't generate empty files for stripped items

[ollie27]

We need to traverse stripped modules to generate redirect pages, but we shouldn't generate
anything else for them.

This now renders the file contents to a Vec before writing it to a file in one go. I think
that's probably a better strategy anyway.

Fixes: #34025

[rust-highfive]

r? @cmr

(rust_highfive has picked a reviewer for you, use r? to override)

[GuillaumeGomez]

Hum... Strange. It doesn't prevent the file creation for #[doc(hidden)] unlike my PR.

[ollie27]

It should do, do you have an example where it doesn't?

Files for #[doc(hidden)] should be created if --no-defaults is passed or the item is reexported somewhere public in which case it gets a redirect page.

What currently happens is empty files are created anyway which I believe is what the problem in #34025 is.

[GuillaumeGomez]

Your solution might be better than mine then. I close my PR in favor of yours. Great job. 😃

[brson]

@bors r+ thanks @GuillaumeGomez@ollie27

[bors]

📌 Commit cfb4ad2 has been approved by brson

[BenTheElder]

Thanks all for working on fixing this so quickly!

This looks like it failed due to the LLVM repository being down (#34009), now that #34016 is in perhaps someone could restart travis? :)

[GuillaumeGomez]

@BenTheElder: No need, bors will test and merge on its own.

[BenTheElder]

Oh cool :-)
I should have read the contributing guide more thoroughly.
Again, thanks!

On Fri, Jun 3, 2016 at 3:41 PM, Guillaume Gomez notifications@github.com
wrote:

@BenTheElderhttps://github.com/BenTheElder: No need, bors will test
and merge on its own.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34045 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA4Bq4u3o67tPWoqeeGIpTG6RhIe2fFBks5qIINagaJpZM4Iswp3
.

[ollie27]

I ran linkchecker after this PR and it looks like I uncovered another rustdoc bug, now getting:

std/char/constant.UNICODE_VERSION.html:50: broken link - rustc_unicode/tables/constant.UNICODE_VERSION.html

I've fixed that in #34068 but assuming bors is gated on linkchecker then this PR won't pass until that is merged. Should I add that commit to this PR if that's easier?

[bors]

⌛ Testing commit cfb4ad2 with merge da75ed2...

[bors]

💔 Test failed - auto-linux-64-opt-rustbuild

[brson]

@ollie27 If you have the patience let's just wait for the other to land.

[ollie27]

@brson#34068 has landed so I think this can just be retried?

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit cfb4ad2 with merge a76698b...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild