Uh oh!
There was an error while loading. Please reload this page.
run rustfmt on liballoc_jemalloc folder - #34086
Merged
Merged
Conversation
rust-highfive
commented
Jun 5, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| "static" | ||
| } else { | ||
| "dylib" | ||
| }; |
Member
There was a problem hiding this comment.
The previous version was much better here.
ContributorAuthor
There was a problem hiding this comment.
cc @nrc . In the If expression. If we return static (?) strings and the total if expression fits under 100 characters, then we format the code like this.let kind = if name.ends_with(".a") { "static" } else { "dylib" };
what do you say?
brson
commented
Jun 7, 2016
Contributor
@nagisa Can we go ahead and land this or do you want that formatting fixed here? |
nagisa
commented
Jun 7, 2016
Member
Its fine I guess. Eventually somebody else will come along and submit a PR with the same thing in it anyway. @bors r+ |
bors
commented
Jun 7, 2016
Collaborator
📌 Commit adf2c43 has been approved by |
sanxiyn
commented
Jun 8, 2016
Contributor
@bors rollup |
bors
commented
Jun 10, 2016
Collaborator
bors added a commit
that referenced
this pull request
Jun 10, 2016
run rustfmt on liballoc_jemalloc folder
sanxiyn added a commit
to sanxiyn/rust
that referenced
this pull request
Jun 10, 2016
…lloc, r=nagisa run rustfmt on liballoc_jemalloc folder
bors
commented
Jun 10, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.