Add explanations for E0503 and E0508. by m-decoster · Pull Request #34133 · rust-lang/rust

m-decoster · 2016-06-07T07:59:24Z

(cannot use .. because it was mutably borrowed, cannot move out of type .., a non-copy fixed-size array)

Part of #32777.

rust-highfive · 2016-06-07T07:59:38Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-06-07T12:24:53Z

This line might mislead users. Please replace it with:
let _sum = value + 1;

GuillaumeGomez · 2016-06-07T12:30:02Z

A few things to correct and it should be good!

m-decoster · 2016-06-07T14:42:10Z

@GuillaumeGomez I have implemented your feedback.

GuillaumeGomez · 2016-06-07T15:59:14Z

"A value was used after it was mutably borrowed."

GuillaumeGomez · 2016-06-07T16:02:19Z

A few other updates to be done. After they're done, please squash your commits. You should have one commit for each error explanation.

m-decoster · 2016-06-07T17:47:35Z

@GuillaumeGomez The commits should be squashed and ready to go. Do you prefer a separate pull request for both error explanations or is this fine as is?

GuillaumeGomez · 2016-06-07T20:35:34Z

No no, one PR is fine. Let me take a last look.

GuillaumeGomez · 2016-06-07T20:36:31Z

You didn't annotate this example. Please do it.

GuillaumeGomez · 2016-06-07T20:37:08Z

Just one last little change and it should be good!

GuillaumeGomez · 2016-06-08T09:26:08Z

All good. Thanks @m-decoster!

@bors: r+ rollup

bors · 2016-06-08T09:26:09Z

📌 Commit 5439806 has been approved by GuillaumeGomez

Add explanations for E0503 and E0508. (cannot use `..` because it was mutably borrowed, cannot move out of type `..`, a non-copy fixed-size array) Part of rust-lang#32777.

bors · 2016-06-10T20:08:42Z

⌛ Testing commit 5439806 with merge aa3adea...

bors · 2016-06-10T20:11:37Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-06-11T14:13:59Z

⌛ Testing commit 5439806 with merge df206f3...

bors · 2016-06-11T15:52:21Z

💔 Test failed - auto-linux-64-opt-rustbuild

GuillaumeGomez · 2016-06-11T16:52:10Z

+fn main() {
+ let mut value = 3;
+ // We clone `value`, creating a copy.
+ let value_cloned = value.cloned();


Oh damn, clone and not cloned!

I can't believe I mistyped that and then missed it and then forgot to run tests. Anyway, how exactly do I solve this now that you've already told bors to rollup? Do I just create a new commit and squash it again? @GuillaumeGomez

m-decoster · 2016-06-12T08:36:17Z

Should compile now.

GuillaumeGomez · 2016-06-12T10:16:18Z

@bors: r+ rollup

bors · 2016-06-12T10:16:18Z

📌 Commit e06fbe1 has been approved by GuillaumeGomez

bors · 2016-06-12T22:35:33Z

⌛ Testing commit e06fbe1 with merge 51d2d3d...

Add explanations for E0503 and E0508. (cannot use `..` because it was mutably borrowed, cannot move out of type `..`, a non-copy fixed-size array) Part of #32777.

bors · 2016-06-13T01:23:05Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned pnkfelix Jun 7, 2016

m-decoster mentioned this pull request Jun 7, 2016
Add error explanations for all error codes #32777
Closed

m-decoster changed the title ~~Add explanation for E0503.~~Add explanations for E0503 and E0508.Jun 7, 2016

GuillaumeGomez reviewed Jun 7, 2016
View reviewed changes

GuillaumeGomez assigned GuillaumeGomez and unassigned pnkfelix Jun 7, 2016

GuillaumeGomez reviewed Jun 7, 2016
View reviewed changes

Comment threadsrc/librustc_borrowck/diagnostics.rs Outdated
GuillaumeGomezJun 7, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A value was used after it was mutably borrowed."

m-decoster force-pushed the master branch from e320f3c to 652711cCompare June 7, 2016 17:45

GuillaumeGomez reviewed Jun 7, 2016
View reviewed changes

Comment threadsrc/librustc_borrowck/diagnostics.rs Outdated
GuillaumeGomezJun 7, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't annotate this example. Please do it.

m-decoster force-pushed the master branch 2 times, most recently from 3a9aaba to 5439806Compare June 8, 2016 06:50

sanxiyn mentioned this pull request Jun 10, 2016
Rollup of 13 pull requests #34196
Closed

GuillaumeGomez reviewed Jun 11, 2016
View reviewed changes

m-decoster added 2 commits June 12, 2016 10:31

Add explanation for E0508
81cd752

Add explanation for E0503
e06fbe1

m-decoster force-pushed the master branch from 5439806 to e06fbe1Compare June 12, 2016 08:32

bors added a commit that referenced this pull request Jun 12, 2016
Auto merge of#34133- m-decoster:master, r=GuillaumeGomez
51d2d3d
Add explanations for E0503 and E0508. (cannot use `..` because it was mutably borrowed, cannot move out of type `..`, a non-copy fixed-size array) Part of #32777.

bors merged commit e06fbe1 into rust-lang:masterJun 13, 2016

Uh oh!

Uh oh!

Conversation

m-decoster commented Jun 7, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 7, 2016

Uh oh!

GuillaumeGomezJun 7, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 7, 2016

Uh oh!

m-decoster commented Jun 7, 2016

Uh oh!

GuillaumeGomezJun 7, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 7, 2016

Uh oh!

m-decoster commented Jun 7, 2016

Uh oh!

GuillaumeGomez commented Jun 7, 2016

Uh oh!

GuillaumeGomezJun 7, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jun 7, 2016

Uh oh!

GuillaumeGomez commented Jun 8, 2016

Uh oh!

bors commented Jun 8, 2016

Uh oh!

bors commented Jun 10, 2016

Uh oh!

bors commented Jun 10, 2016

Uh oh!

bors commented Jun 11, 2016

Uh oh!

bors commented Jun 11, 2016

Uh oh!

GuillaumeGomezJun 11, 2016

Choose a reason for hiding this comment

Uh oh!

m-decosterJun 11, 2016

Choose a reason for hiding this comment

Uh oh!

sanxiynJun 12, 2016

Choose a reason for hiding this comment

Uh oh!

m-decoster commented Jun 12, 2016

Uh oh!

GuillaumeGomez commented Jun 12, 2016

Uh oh!

bors commented Jun 12, 2016

Uh oh!

bors commented Jun 12, 2016

Uh oh!

bors commented Jun 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

m-decoster commented Jun 7, 2016•
edited
Loading