Skip to content

Fixed: conflicting spelling of "Jon Snow" - #34134

Closed
hoodie wants to merge 2 commits into
rust-lang:masterfrom
hoodie:bug/john_and_jon
Closed

Fixed: conflicting spelling of "Jon Snow"#34134
hoodie wants to merge 2 commits into
rust-lang:masterfrom
hoodie:bug/john_and_jon

Conversation

@hoodie

Copy link
Copy Markdown
Contributor

I probably had not even noticed, if there hadn't been a different spelling in the error index.

Cheers
Winter is Coming!

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Oh damn it! Thanks so much for this fix!

Use the force Harry!

Gandalf

@bors: r+ rollup

@bors

bors commented Jun 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4761de6 has been approved by GuillaumeGomez

@hoodie
hoodieforce-pushed the bug/john_and_jon branch from a110e7a to b602e06CompareJune 7, 2016 13:28
@hoodie
hoodieforce-pushed the bug/john_and_jon branch from b602e06 to af691a7CompareJune 7, 2016 13:30
@brson

brson commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Nice.

@hoodie

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez I had pushed another changed after 4761de6

@GuillaumeGomez

Copy link
Copy Markdown
Member

@hoodie: Arf. Please squash your commits and then I r+ again.

@bors: r-

@hoodie

Copy link
Copy Markdown
ContributorAuthor

There we go #34160@GuillaumeGomez

@GuillaumeGomez

Copy link
Copy Markdown
Member

Why didn't you do it directly in here? :-/

Well, I close this one then.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hoodie@rust-highfive@GuillaumeGomez@bors@brson@arielb1