Uh oh!
There was an error while loading. Please reload this page.
Implementation of #34168 - #34186
Conversation
8fe5d9c to
44060f3CompareStrange... We can't see my changes on here but we can on my branch: https://github.com/GuillaumeGomez/rust/blob/err-code-check/src/librustdoc/test.rs#L291 . So like we said when I saw @alexcrichton (I can finally say it haha), it seems it can be merged and then it'll be updated once the new error lib is out (keep me up to date on this @jonathandturner! :p). |
There was a problem hiding this comment.
I think this should be a separate 'feature gate'. Let's not just tie it to compile-fail but add another feature like check_error_codes.
a3fa261 to
bdaf812CompareGuillaumeGomez
commented
Jun 13, 2016
Updated. |
GuillaumeGomez
commented
Jun 14, 2016
@alexcrichton: Up? |
There was a problem hiding this comment.
Can't you leave these unchanged and always use vec![] in t? Or are there other calls I'm not seeing?
There was a problem hiding this comment.
No, you're absolutely right.
bdaf812 to
ddfaf10CompareGuillaumeGomez
commented
Jun 20, 2016
Updated. |
alexcrichton
commented
Jun 20, 2016
bors
commented
Jun 20, 2016
Implementation of #34168 r? @brson cc @alexcrichton cc @steveklabnik cc @jonathandturner I only updated `librustc_privacy/diagnostics.rs`, and I already found a case where the code doesn't throw the expected error code (E0448). Fixes#34168.
r? @brson
cc @alexcrichton
cc @steveklabnik
cc @jonathandturner
I only updated
librustc_privacy/diagnostics.rs, and I already found a case where the code doesn't throw the expected error code (E0448).Fixes#34168.