Skip to content

Allow MultiItemModifiers to expand into zero or many items - #34253

Merged
bors merged 4 commits into
rust-lang:masterfrom
jseyfried:improve_multi_modifiers
Jun 23, 2016
Merged

Allow MultiItemModifiers to expand into zero or many items#34253
bors merged 4 commits into
rust-lang:masterfrom
jseyfried:improve_multi_modifiers

Conversation

@jseyfried

@jseyfriedjseyfried commented Jun 13, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#34223.
r? @nrc

@jseyfried

jseyfried commented Jun 13, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

While this is a syntax-[breaking-change] in theory, it is highly unlikely to cause breakage in practice. In particular, it will not break any crates on github.

After this PR, MultiItemModifiers will be at least as powerful as MultiItemDecorators, except that MultiItemDecorators have access to expanded AST (c.f. #34010). If we revert #34010 and instead fix #32950 some other way (c.f. this comment), MultiItemModifiers will be at least as powerful as MultiItemDecorators without exception.

@jseyfriedjseyfried mentioned this pull request Jun 13, 2016
Closed
@jseyfried
jseyfriedforce-pushed the improve_multi_modifiers branch 7 times, most recently from 0978ba2 to 8cb439dCompareJune 15, 2016 09:12
@jseyfried
jseyfriedforce-pushed the improve_multi_modifiers branch from 5af255a to 58372afCompareJune 16, 2016 05:46
@nrc

nrc commented Jun 23, 2016

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jun 23, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 58372af has been approved by nrc

@nrcnrc mentioned this pull request Jun 23, 2016
Closed
@bors

bors commented Jun 23, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 58372af with merge 3908913...

bors added a commit that referenced this pull request Jun 23, 2016
@bors
Auto merge of#34253- jseyfried:improve_multi_modifiers, r=nrc
3908913
Allow `MultiItemModifier`s to expand into zero or many items
Fixes#34223.
r? @nrc
@bors

bors commented Jun 23, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors
bors merged commit 58372af into rust-lang:masterJun 23, 2016
This was referenced Jun 23, 2016
Merged
Closed
@jseyfriedjseyfried mentioned this pull request Jul 5, 2016
Merged
@jseyfriedjseyfried mentioned this pull request Jul 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jseyfried@nrc@bors