Skip to content

Don't translate vtable methods with Self: Sized bounds. - #34419

Merged
bors merged 1 commit into
rust-lang:masterfrom
eddyb:virtually-inexistent
Jun 27, 2016
Merged

Don't translate vtable methods with Self: Sized bounds.#34419
bors merged 1 commit into
rust-lang:masterfrom
eddyb:virtually-inexistent

Conversation

@eddyb

Copy link
Copy Markdown
Contributor

Fixes#34416.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister

Copy link
Copy Markdown
Member

This looks good to me but I don't feel competent enough to r+ this on my own.

@michaelwoerister

Copy link
Copy Markdown
Member

cc @rust-lang/compiler

@Aatch

Copy link
Copy Markdown
Contributor

This looks like it could just be self.object_safety_violation_for_method(...).is_none(), since it's basically identical to the function above it.

@eddyb

Copy link
Copy Markdown
ContributorAuthor

@Aatch The effect is opposite: Self: Sized methods never have object-safety implications, so .is_none() would return true, but you want false because they're not in the vtable.

@Aatch

Copy link
Copy Markdown
Contributor

@eddyb oh right, I missed that. Seems fine then.

@Aatch

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 096ae80 has been approved by Aatch

@bors

bors commented Jun 27, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 096ae80 with merge b42884f...

bors added a commit that referenced this pull request Jun 27, 2016
Don't translate vtable methods with Self: Sized bounds.
Fixes#34416.
@bors
bors merged commit 096ae80 into rust-lang:masterJun 27, 2016
@eddyb
eddyb deleted the virtually-inexistent branch June 27, 2016 11:57
@pnkfelixpnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2016
@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 3, 2016
@alexcrichton

Copy link
Copy Markdown
Member

Discussed with compiler team in email and sentiment was that this is small enough and important enough to backport, accepting for backport.

@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 3, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@eddyb@rust-highfive@michaelwoerister@Aatch@bors@alexcrichton@nikomatsakis@pnkfelix