Skip to content

Just pass in NodeId to FunctionContext::new instead of looking it up. - #34658

Merged
bors merged 1 commit into
rust-lang:masterfrom
luqmana:34592-nested_returns
Jul 7, 2016
Merged

Just pass in NodeId to FunctionContext::new instead of looking it up.#34658
bors merged 1 commit into
rust-lang:masterfrom
luqmana:34592-nested_returns

Conversation

@luqmana

@luqmanaluqmana commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

Fixes#34592.

@rust-highfive

rust-highfive commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

eddyb commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

Ugh, the things we do for old trans. @bors r+

@bors

bors commented Jul 5, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit fd3b464 has been approved by eddyb

@alexcrichton

alexcrichton commented Jul 5, 2016

Copy link
Copy Markdown
Member

Awesome, thanks for the fix @luqmana!

@bors

bors commented Jul 7, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fd3b464 with merge a362b94...

@bors

bors commented Jul 7, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@arielb1

arielb1 commented Jul 7, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@bors retry

random timeout

@bors

bors commented Jul 7, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fd3b464 with merge 9c1783a...

bors added a commit that referenced this pull request Jul 7, 2016
@bors
Auto merge of#34658- luqmana:34592-nested_returns, r=eddyb
9c1783a
Just pass in NodeId to FunctionContext::new instead of looking it up.
Fixes#34592.
@bors

bors commented Jul 7, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 9c1783a to master...

@bors
bors merged commit fd3b464 into rust-lang:masterJul 7, 2016
@luqmana
luqmana deleted the 34592-nested_returns branch July 7, 2016 21:03
@alexcrichtonalexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2016
@alexcrichton

alexcrichton commented Jul 26, 2016

Copy link
Copy Markdown
Member

Nominating for beta according to this comment: #34592 (comment)

@eddybeddyb mentioned this pull request Jul 26, 2016
Closed
@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 28, 2016
@nikomatsakis

nikomatsakis commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Accepted for backport.

@alexcrichtonalexcrichton mentioned this pull request Aug 1, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 2, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AatchAatch

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@luqmana@rust-highfive@eddyb@bors@alexcrichton@arielb1@nikomatsakis@brson@Aatch