Add method `String::insert_str` by murarth · Pull Request #34771 · rust-lang/rust

murarth · 2016-07-11T22:08:56Z

No description provided.

rust-highfive · 2016-07-11T22:09:10Z

(rust_highfive has picked a reviewer for you, use r? to override)

brson · 2016-07-11T22:15:48Z

The functionality makes sense to me. Is there really no easy way to do this today? cc @rust-lang/libs

brson · 2016-07-11T22:16:35Z

@murarth Can you please change the stability attribute to 'unstable'? New features mostly don't get stabilized immediately.

murarth · 2016-07-11T22:16:42Z

This is pretty common functionality whose absence I thought was a bit strange. The signature of insert_str mirrors insert and the name goes along with the push/push_str methods.

This seems to me like a sufficiently small addition not to warrant an RFC, so I thought I'd go ahead and submit it.

The #[stable] attribute on the new method was just to get it to pass make check on my machine. I will gladly change it if that's deemed appropriate.

murarth · 2016-07-11T22:19:14Z

@brson: Sure, I just didn't know what to put for issue or whether the compiler would accept it without that.

brson · 2016-07-11T22:56:28Z

@murarth "0" is fine for now. If this PR is accepted then before it's merged you'll need to file a 'tracking' issue on the issue tracker to fill in the real number.

murarth · 2016-07-11T23:02:46Z

@brson: Okay. It's unstable now.

BurntSushi · 2016-07-11T23:06:12Z

This seems fine to me. I agree that it's small enough that we probably wouldn't need an RFC for it.

sfackler · 2016-07-12T10:04:39Z

LGTM

ollie27 · 2016-07-12T11:48:18Z

This is covered by String::splicerust-lang/rfcs#1432.

alexcrichton · 2016-07-12T14:48:35Z

Ah yeah I was also under the impression that this was going to be functionality implemented through splice that @ollie27 linked to. Perhaps the PR to implement could be revived?

murarth · 2016-07-12T17:56:45Z

I wasn't aware of that RFC. Even so, splice looks to be a slightly different kind of operation. If I understand correctly, then inserting a string without replacing would look something like a.splice(idx..idx, b), which looks a bit odd.

alexcrichton · 2016-07-12T23:13:59Z

Yeah it's true that does look a bit odd! We might still have API room to add a function like this, and to me it seems to fit all existing conventions so I'd also be fine layering this on top (although it'd probably use splice as an implementation detail eventually)

aturon · 2016-07-13T02:49:59Z

I'm likewise happy having this as a convenience on top of splice.

alexcrichton · 2016-07-19T04:23:54Z

Discussed during libs triage today the decision was to merge, thanks for the PR @murarth!

@bors: r+

bors · 2016-07-19T04:23:55Z

📌 Commit 0bcf64c has been approved by alexcrichton

bors · 2016-07-19T19:44:14Z

⌛ Testing commit 0bcf64c with merge 67f0941...

bors · 2016-07-19T19:46:17Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-07-19T19:56:07Z

@bors: retry

Cascading failure on bots when interrupted when performing git operations #34595

On Tue, Jul 19, 2016 at 12:46 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/4936
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NRWv0XHT0MiKu8iESzlmdl58ApFks5qXSmMgaJpZM4JJ1x-
.

bors · 2016-07-20T04:15:10Z

⌛ Testing commit 0bcf64c with merge 482a03c...

bors · 2016-07-20T04:19:19Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-07-20T05:15:39Z

@bors: retry

Cascading failure on bots when interrupted when performing git operations #34595

On Tue, Jul 19, 2016 at 9:19 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1822
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95N5Rz03tPpQZoHZrYQ9GlVcecAlDks5qXaHKgaJpZM4JJ1x-
.

bors · 2016-07-21T00:36:19Z

⌛ Testing commit 0bcf64c with merge 44b6d38...

bors · 2016-07-21T00:40:19Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

alexcrichton · 2016-07-21T07:12:59Z

@bors: retry

On Wed, Jul 20, 2016 at 5:40 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1861
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95EOEDk87Sfz4yXMXNMkK9T3hotQGks5qXr_2gaJpZM4JJ1x-
.

bors · 2016-07-21T18:56:56Z

⌛ Testing commit 0bcf64c with merge 6722228...

bors · 2016-07-21T19:21:32Z

💔 Test failed - auto-linux-64-debug-opt

alexcrichton · 2016-07-21T20:28:59Z

@bors: retry

sorry for the number of retries...

On Thu, Jul 21, 2016 at 12:21 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3189
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I7ulfxkYyExSanlqzqda1L0nfIvks5qX8a_gaJpZM4JJ1x-
.

bors · 2016-07-22T08:36:23Z

⌛ Testing commit 0bcf64c with merge d15e265...

Add method `String::insert_str`

bors · 2016-07-22T11:30:07Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing d15e265 to master...

murarth · 2016-08-09T17:04:20Z

Just curious, will the libs team create a tracking issue for this at some time or am I supposed to file one myself?

alexcrichton · 2016-08-09T17:31:29Z

Oh oops! Thanks for the reminder @murarth! This actually should have held off on landing until a tracking issue was made, but oh well.

If you want to open a tracking issue and send a PR updating the reference here I'll r+ and tag appropriately.

rust-highfive assigned brson Jul 11, 2016

brson added I-nominated T-libs-api [DEPRECATED; DO NOT USE] labels Jul 11, 2016

Add method String::insert_str
0bcf64c

brson removed the I-nominated label Jul 21, 2016

bors added a commit that referenced this pull request Jul 22, 2016
Auto merge of#34771- murarth:string-insert-str, r=alexcrichton
d15e265
Add method `String::insert_str`

bors merged commit 0bcf64c into rust-lang:masterJul 22, 2016

murarth deleted the string-insert-str branch July 22, 2016 16:14

murarth mentioned this pull request Aug 9, 2016
Tracking issue for String::insert_str#35553
Closed

mbrubeck mentioned this pull request Sep 29, 2017
New str and String API rust-lang/rfcs#1253
Closed

Uh oh!

Uh oh!

Conversation

murarth commented Jul 11, 2016

Uh oh!

rust-highfive commented Jul 11, 2016

Uh oh!

brson commented Jul 11, 2016

Uh oh!

brson commented Jul 11, 2016

Uh oh!

murarth commented Jul 11, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

murarth commented Jul 11, 2016

Uh oh!

brson commented Jul 11, 2016

Uh oh!

murarth commented Jul 11, 2016

Uh oh!

BurntSushi commented Jul 11, 2016

Uh oh!

sfackler commented Jul 12, 2016

Uh oh!

ollie27 commented Jul 12, 2016

Uh oh!

alexcrichton commented Jul 12, 2016

Uh oh!

murarth commented Jul 12, 2016

Uh oh!

alexcrichton commented Jul 12, 2016

Uh oh!

aturon commented Jul 13, 2016

Uh oh!

alexcrichton commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

alexcrichton commented Jul 19, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

alexcrichton commented Jul 20, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

alexcrichton commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

alexcrichton commented Jul 21, 2016

Uh oh!

bors commented Jul 22, 2016

Uh oh!

bors commented Jul 22, 2016

Uh oh!

murarth commented Aug 9, 2016

Uh oh!

alexcrichton commented Aug 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

murarth commented Jul 11, 2016•
edited
Loading