mk: Stop using cmake for compiler-rt by alexcrichton · Pull Request #34873 · rust-lang/rust

alexcrichton · 2016-07-17T00:26:13Z

The compiler-rt build system has been a never ending cause of pain for Rust
unfortunately:

The build system is very difficult to invoke and configure to only build
compiler-rt, especially across platforms.
The standard build system doesn't actually do what we want, not working for
some of our platforms and requiring a significant number of patches on our end
which are difficult to apply when updating compiler-rt.
Compiling compiler-rt requires LLVM to be compiled, which... is a big
dependency! This also means that over time compiler-rt is not guaranteed to
build against older versions of LLVM (or newer versions), and we often want to
work with multiple versions of LLVM simultaneously.

The makefiles and rustbuild already know how to compile C code, the code here is
far from the only C code we're compiling. This patch jettisons all logic to
work with compiler-rt's build system and just goes straight to the source. We
just list all files manually (copied from compiler-rt's
lib/builtins/CMakeLists.txt) and compile them into an archive.

It's likely that this means we'll fail to pick up new files when we upgrade
compiler-rt, but that seems like a much less significant cost to pay than what
we're currently paying.

cc #34400, first steps towards that

rust-highfive · 2016-07-17T00:26:24Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2016-07-17T07:08:54Z

☔ The latest upstream changes (presumably #34606) made this pull request unmergeable. Please resolve the merge conflicts.

brson · 2016-07-18T20:52:58Z

@bors r+

bors · 2016-07-18T20:52:59Z

📌 Commit d6c0fc2 has been approved by brson

badboy · 2016-07-18T22:36:38Z

rustc will fail to compile here. That argument to join there should be src, right?

Oops, indeed!

alexcrichton · 2016-07-18T23:17:52Z

@bors: r=brson c0ccbf1

bors · 2016-07-19T01:06:12Z

⌛ Testing commit c0ccbf1 with merge 0ab82ae...

bors · 2016-07-19T01:09:24Z

💔 Test failed - auto-mac-32-opt

alexcrichton · 2016-07-19T01:12:57Z

@bors: r=brson

bors · 2016-07-19T01:12:57Z

📌 Commit 7b68f17 has been approved by brson

alexcrichton · 2016-07-19T04:51:52Z

@bors: p=1

Blocking the LLVM upgrade which is blocking MIR

bors · 2016-07-19T06:20:39Z

⌛ Testing commit 7b68f17 with merge c97c785...

bors · 2016-07-19T06:25:54Z

💔 Test failed - auto-win-msvc-64-opt

We're not writing C code, so there's not really much of a reason for us to get warnings and errors from code we haven't written!

alexcrichton · 2016-07-19T07:15:22Z

@bors: r=brson

bors · 2016-07-19T07:15:24Z

📌 Commit f168d17 has been approved by brson

bors · 2016-07-19T08:17:49Z

⌛ Testing commit f168d17 with merge c2d81d5...

bors · 2016-07-19T08:20:49Z

💔 Test failed - auto-linux-64-cross-freebsd

bors · 2016-07-20T18:20:27Z

⌛ Testing commit 0a66ae3 with merge 22abe50...

bors · 2016-07-20T18:24:10Z

💔 Test failed - auto-linux-64-x-android-t

The compiler-rt build system has been a never ending cause of pain for Rust unfortunately: * The build system is very difficult to invoke and configure to only build compiler-rt, especially across platforms. * The standard build system doesn't actually do what we want, not working for some of our platforms and requiring a significant number of patches on our end which are difficult to apply when updating compiler-rt. * Compiling compiler-rt requires LLVM to be compiled, which... is a big dependency! This also means that over time compiler-rt is not guaranteed to build against older versions of LLVM (or newer versions), and we often want to work with multiple versions of LLVM simultaneously. The makefiles and rustbuild already know how to compile C code, the code here is far from the *only* C code we're compiling. This patch jettisons all logic to work with compiler-rt's build system and just goes straight to the source. We just list all files manually (copied from compiler-rt's lib/builtins/CMakeLists.txt) and compile them into an archive. It's likely that this means we'll fail to pick up new files when we upgrade compiler-rt, but that seems like a much less significant cost to pay than what we're currently paying. cc rust-lang#34400, first steps towards that

alexcrichton · 2016-07-20T20:22:32Z

@bors: r=brson

bors · 2016-07-20T20:22:33Z

📌 Commit ee6011f has been approved by brson

bors · 2016-07-20T23:42:53Z

⌛ Testing commit ee6011f with merge cc548ca...

bors · 2016-07-20T23:49:36Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-07-20T23:52:00Z

@bors: retry

Weird network error

bors · 2016-07-21T00:31:08Z

⌛ Testing commit ee6011f with merge a33622c...

bors · 2016-07-21T00:36:17Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

alexcrichton · 2016-07-21T02:01:58Z

@bors: retry

Cascading failure on bots when interrupted when performing git operations #34595

bors · 2016-07-21T02:02:01Z

⌛ Testing commit ee6011f with merge e7c822c...

…=brson mk: Stop using cmake for compiler-rt The compiler-rt build system has been a never ending cause of pain for Rust unfortunately: * The build system is very difficult to invoke and configure to only build compiler-rt, especially across platforms. * The standard build system doesn't actually do what we want, not working for some of our platforms and requiring a significant number of patches on our end which are difficult to apply when updating compiler-rt. * Compiling compiler-rt requires LLVM to be compiled, which... is a big dependency! This also means that over time compiler-rt is not guaranteed to build against older versions of LLVM (or newer versions), and we often want to work with multiple versions of LLVM simultaneously. The makefiles and rustbuild already know how to compile C code, the code here is far from the *only* C code we're compiling. This patch jettisons all logic to work with compiler-rt's build system and just goes straight to the source. We just list all files manually (copied from compiler-rt's lib/builtins/CMakeLists.txt) and compile them into an archive. It's likely that this means we'll fail to pick up new files when we upgrade compiler-rt, but that seems like a much less significant cost to pay than what we're currently paying. cc #34400, first steps towards that

bors · 2016-07-21T04:09:14Z

💔 Test failed - auto-win-gnu-32-opt

alexcrichton · 2016-07-21T04:11:35Z

@bors: retry

Spurious access violation on Windows #33434

bors · 2016-07-21T04:11:38Z

⚡ Previous build results for auto-linux-64-cargotest, auto-mac-cross-ios-opt, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

bors · 2016-07-21T08:35:48Z

badboy · 2016-07-21T09:08:15Z

\o/ That took quite some time

eminence · 2016-07-21T12:12:16Z

@alexcrichton wins another epic battle with @bors 🎉

Ms2ger · 2016-07-23T10:43:59Z

What's up with the two gcc crates in Cargo.lock?

alexcrichton · 2016-07-23T17:24:06Z

@Ms2ger one's from git and one's from crates.io

Remove CMake workaround This isn't needed anymore as we aren't using CMake to build compiler-rt since rust-lang#34873.

rust-highfive assigned brson Jul 17, 2016

alexcrichton mentioned this pull request Jul 17, 2016
Move compiler-rt build into a crate dependency of libcore #34400
Closed

alexcrichton force-pushed the down-with-compiler-rt-for-good branch from c881d84 to d6c0fc2Compare July 17, 2016 17:58

alexcrichton mentioned this pull request Jul 18, 2016
LLVM upgrade #34743
Merged
3 tasks

MagaTailor mentioned this pull request Jul 18, 2016
compiler-rt doesn't build with cmake #34867
Closed

badboy reviewed Jul 18, 2016
View reviewed changes

alexcrichton force-pushed the down-with-compiler-rt-for-good branch from d6c0fc2 to c0ccbf1Compare July 18, 2016 23:17

alexcrichton force-pushed the down-with-compiler-rt-for-good branch from c0ccbf1 to 7b68f17Compare July 19, 2016 01:12

mk: Remove -Wall -Werror everywhere
b45c15e
We're not writing C code, so there's not really much of a reason for us to get warnings and errors from code we haven't written!

alexcrichton force-pushed the down-with-compiler-rt-for-good branch 2 times, most recently from fb25076 to f168d17Compare July 19, 2016 07:15

bstrie added this to the Launch MIR into Orbit milestone Jul 20, 2016

alexcrichton force-pushed the down-with-compiler-rt-for-good branch from 0a66ae3 to ee6011fCompare July 20, 2016 20:22

bors merged commit ee6011f into rust-lang:masterJul 21, 2016

alexcrichton deleted the down-with-compiler-rt-for-good branch July 21, 2016 15:43

sanxiyn mentioned this pull request Aug 1, 2016
Remove CMake workaround #35157
Merged

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Aug 1, 2016
Rollup merge ofrust-lang#35157- sanxiyn:remove-workaround, r=eddyb
5fb13cf
Remove CMake workaround This isn't needed anymore as we aren't using CMake to build compiler-rt since rust-lang#34873.

Uh oh!

Uh oh!

Conversation

alexcrichton commented Jul 17, 2016

Uh oh!

rust-highfive commented Jul 17, 2016

Uh oh!

bors commented Jul 17, 2016

Uh oh!

brson commented Jul 18, 2016

Uh oh!

bors commented Jul 18, 2016

Uh oh!

badboyJul 18, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichtonJul 18, 2016

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Jul 18, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

alexcrichton commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

alexcrichton commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

alexcrichton commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 19, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

alexcrichton commented Jul 20, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

bors commented Jul 20, 2016

Uh oh!

alexcrichton commented Jul 20, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

alexcrichton commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

alexcrichton commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

bors commented Jul 21, 2016

Uh oh!

badboy commented Jul 21, 2016

Uh oh!

eminence commented Jul 21, 2016

Uh oh!

Ms2ger commented Jul 23, 2016

Uh oh!

alexcrichton commented Jul 23, 2016