Uh oh!
There was an error while loading. Please reload this page.
Properly feature gate all unstable ABIs - #34904
Merged
Merged
Conversation
pnkfelix
commented
Jul 19, 2016
Contributor
@petrochenkov to be honest I was expecting a warning cycle. For now I'll at least tag this as needing a crater run. |
petrochenkov
commented
Jul 19, 2016
ContributorAuthor
I'd be surprised if it broke anything in practice, but let's see what crater will say. |
pnkfelix
commented
Jul 19, 2016
Contributor
The patch itself looks fine, so r=me apart from the question of whether it should go through a warning cycle. I'll nominate for discussion at lang team mtg. |
eddyb
commented
Jul 28, 2016
Contributor
Will start a crater run now. Sorry about that, we had network issues with GitHub for a while. |
eddyb
commented
Jul 29, 2016
Contributor
Crater report shows 0 regressions. |
nikomatsakis
commented
Jul 29, 2016
Contributor
OK, let's do it. |
nikomatsakis
commented
Jul 29, 2016
Contributor
@bors r+ |
bors
commented
Jul 29, 2016
Collaborator
📌 Commit 9292c0b has been approved by |
alexcrichton
commented
Jul 29, 2016
Member
@bors: rollup assuming this isn't very platform-specific and green travis means it's good to go whenever |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 30, 2016
Properly feature gate all unstable ABIs Fixesrust-lang#34900 [breaking-change] r? @pnkfelix --- Function-visiting machinery for AST/HIR is surprisingly error-prone, it's *very* easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind rust-lang#34900. I'll try to restructure these visitors a bit and send one more PR later.
bors
commented
Jul 30, 2016
Collaborator
bors added a commit
that referenced
this pull request
Jul 30, 2016
Properly feature gate all unstable ABIs Fixes#34900 [breaking-change] r? @pnkfelix --- Function-visiting machinery for AST/HIR is surprisingly error-prone, it's *very* easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind #34900. I'll try to restructure these visitors a bit and send one more PR later.
bors
commented
Jul 31, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#34900
[breaking-change]
r? @pnkfelix
Function-visiting machinery for AST/HIR is surprisingly error-prone, it's very easy to miss some cases or visit something twice while writing a visitor. This is the true problem behind #34900. I'll try to restructure these visitors a bit and send one more PR later.