macros: Improve `tt` matchers by jseyfried · Pull Request #34908 · rust-lang/rust

jseyfried · 2016-07-18T23:21:08Z

jseyfried · 2016-07-19T08:40:50Z

Looks like this breaks some non-trivial macro-expanded macro_rules!, which I thought were already broken but actually happen to work in some cases due to the strange behavior of today's tt fragments.

This should be able to land without breakage once I fix non-trivial macro-expanded macro_rules! (EDIT: c.f. #34925).

jseyfried · 2016-07-19T20:40:36Z

cc @eddyb

eddyb · 2016-07-19T21:01:36Z

LGTM, pending on #34925 landing.

jseyfried · 2016-07-26T01:24:57Z

This is ready to land now pending review (cc @nrc).
The travis failure is spurious.

nrc · 2016-07-26T04:52:08Z

@bors: r+

bors · 2016-07-26T04:52:09Z

📌 Commit 082970c has been approved by nrc

bors · 2016-07-26T10:13:44Z

⌛ Testing commit 082970c with merge ee0dc3a...

bors · 2016-07-26T10:16:10Z

💔 Test failed - auto-win-msvc-64-opt

eddyb · 2016-07-26T10:20:13Z

@bors retry

bors · 2016-07-26T10:20:53Z

⌛ Testing commit 082970c with merge bb5f00b...

bors · 2016-07-26T10:24:23Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-07-26T17:19:19Z

@bors: retry

On Tue, Jul 26, 2016 at 3:24 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1950
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34908 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KyTz9n_saqsgq37uFRMoYY94xe5ks5qZeBagaJpZM4JPPEN
.

bors · 2016-07-28T00:35:16Z

⌛ Testing commit 082970c with merge d69a893...

bors · 2016-07-28T01:58:03Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

jseyfried · 2016-07-28T02:16:59Z

@bors r=nrc

bors · 2016-07-28T02:17:00Z

📌 Commit 4485502 has been approved by nrc

bors · 2016-07-28T05:34:12Z

⌛ Testing commit 4485502 with merge 4e0fcad...

alexcrichton · 2016-07-28T07:01:32Z

@bors: retry force clean

restarted buildbot

bors · 2016-07-28T07:01:54Z

⌛ Testing commit 4485502 with merge 1895bf7...

@nrc

macros: Improve `tt` matchers Fixes#5846, fixes#22819. r? @nrc

bors · 2016-07-28T11:14:06Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 1895bf7 to master...

durka · 2016-08-03T04:31:08Z

Has this innocuously named PR finally killed the reparse hack? https://is.gd/tV0iba

macro_rules! as_item {($i:item) => { $i }}macro_rules! foo {($x:tt) => {//as_item!{ // uncomment for stablestructItem($x);//}}}foo!(i32);fnmain(){}

eddyb · 2016-08-03T04:33:10Z

@durka That's what was fixed here, yeah.

durka · 2016-08-03T04:34:05Z

That makes me unjustifiably happy. Please tag this with relnotes, trumpet from rooftops, etc.

Rust 1.11 had an old behaviour for `tt` matchers that has been fixed in Rust 1.12 (rust-lang/rust#34908).

rust-highfive assigned nrc Jul 18, 2016

This was referenced Jul 18, 2016
tt-macro doesn't work #5846
Closed
Traverse interpolated TTs so we can parse them as other things #22819
Closed

macros: Improve tt fragments
41745f3

jseyfried force-pushed the improve_tt_matchers branch 2 times, most recently from ddf7ae9 to 082970cCompare July 25, 2016 18:03

Add regression test
4485502

jseyfried force-pushed the improve_tt_matchers branch from 082970c to 4485502Compare July 28, 2016 02:16

bors added a commit that referenced this pull request Jul 28, 2016
Auto merge of#34908- jseyfried:improve_tt_matchers, r=nrc
1895bf7
macros: Improve `tt` matchers Fixes#5846, fixes#22819. r? @nrc

bors merged commit 4485502 into rust-lang:masterJul 28, 2016

nrc added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 3, 2016

jseyfried mentioned this pull request Aug 4, 2016
Add a literal fragment specifier to macro_rules!. rust-lang/rfcs#1576
Merged

durka mentioned this pull request Aug 17, 2016
1.11 changelog #35736
Merged

jseyfried deleted the improve_tt_matchers branch October 16, 2016 09:30

jseyfried mentioned this pull request Nov 3, 2016
macros: improve expansion performance #37569
Merged

hcpl mentioned this pull request Dec 22, 2018
Fix expanding to short versions of constructs lambda-fairy/if_chain#8
Merged

hcpl added a commit to hcpl/if_chain that referenced this pull request Jan 27, 2019
Bump minimum Rust to 1.12.0
97c59e3
Rust 1.11 had an old behaviour for `tt` matchers that has been fixed in Rust 1.12 (rust-lang/rust#34908).

jplatte mentioned this pull request Feb 10, 2020
Make the crate no_std kellytk/debug_panic#4
Merged

Uh oh!

Uh oh!

Conversation

jseyfried commented Jul 18, 2016

Uh oh!

jseyfried commented Jul 19, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jseyfried commented Jul 19, 2016

Uh oh!

eddyb commented Jul 19, 2016

Uh oh!

jseyfried commented Jul 26, 2016

Uh oh!

nrc commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

eddyb commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

alexcrichton commented Jul 26, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

jseyfried commented Jul 28, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

alexcrichton commented Jul 28, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

bors commented Jul 28, 2016

Uh oh!

durka commented Aug 3, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb commented Aug 3, 2016

Uh oh!

durka commented Aug 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jseyfried commented Jul 19, 2016•
edited
Loading

durka commented Aug 3, 2016•
edited
Loading