Add diagnostics for rustc_metadata by jhod0 · Pull Request #34970 · rust-lang/rust

jhod0 · 2016-07-22T04:59:09Z

Diagnostics messages are added for:
E0466 E0467 E0468 E0469 E0470

Additionally, rustc_driver is modified so that rustc_metadata diagnostics are available at runtime

rust-highfive · 2016-07-22T04:59:23Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-07-22T09:18:34Z

Thanks for the PR! However please run make tidy and fix the issues please.

GuillaumeGomez · 2016-07-22T09:19:16Z

 all_errors.extend_from_slice(&rustc_privacy::DIAGNOSTICS);
 all_errors.extend_from_slice(&rustc_trans::DIAGNOSTICS);
 all_errors.extend_from_slice(&rustc_const_eval::DIAGNOSTICS);
+ all_errors.extend_from_slice(&rustc_metadata::DIAGNOSTICS);


Why adding this? (I'm curious)

GuillaumeGomez · 2016-07-22T09:21:50Z

Also, you didn't follow the guidelines to write error codes that you can find here.

jhod0 · 2016-07-22T14:34:26Z

I didn't think my original messages were in conflict with the guidelines - hopefully there is no problem now

jhod0 · 2016-07-22T15:12:03Z

Looks like the tidy fixes did not work - I'll fix that later today

GuillaumeGomez · 2016-07-22T17:18:01Z

Sure, just ping me back once done.

jhod0 · 2016-07-22T21:27:24Z

@GuillaumeGomez should be good now

jhod0 · 2016-07-22T22:25:28Z

OK I'm pretty unsure what the problem is, there are a few test failures

jhod0 · 2016-07-22T22:57:27Z

Now that the metadata diagnostics are registered, it runs some doctests which were not previously registered.

So they had never been checked before, and naturally, they failed. I set them to ignore

That's not a cop-out: the failing tests were about attributes to extern crate's, there was no real functionality going on. I suppose they could be set to compile_fail

jhod0 · 2016-07-23T04:12:26Z

@GuillaumeGomez All good now, sorry for the hassle!

GuillaumeGomez · 2016-07-23T08:55:03Z

 A link name was given with an empty name. Erroneous code example:

-```
+```ignore


It should be compile_fail,E0454 and not ignore.

GuillaumeGomez · 2016-07-23T09:01:59Z

+
+Causes of this error:
+
+```ignore


Shouldn't be ignore.

GuillaumeGomez · 2016-07-23T09:05:14Z

I just checked tidy and RFC things for now. Please update and then I'll check the content.

In order to fix failing tests of rust-lang#35011

jhod0 · 2016-07-30T19:45:54Z

@GuillaumeGomez passing checks

GuillaumeGomez · 2016-07-31T10:40:24Z

+
+Erroneous code xamples:
+
+```compile_fail


Missing the expected error code.

GuillaumeGomez · 2016-07-31T10:45:27Z

Beside all this, your PR should contain a commit for each error code (so 3 if I'm not wrong).

nikomatsakis · 2016-08-16T00:49:03Z

I'm going to go ahead and close this PR for inactivity. @jhod0 please feel free to re-open once you've had a chance to address @GuillaumeGomez's comments! <3

Jackson O'Donnell added 3 commits July 21, 2016 03:16

Added messages for E0467, E0468, E0469, and E0470
178f8a8

registered diagnostics for rustc_metadata
4cbbe51

added diagnostic message for E0466
eead207

rust-highfive assigned nikomatsakis Jul 22, 2016

GuillaumeGomez reviewed Jul 22, 2016
View reviewed changes

Jackson O'Donnell added 2 commits July 22, 2016 09:20

fixed make tidy errors
3476aad

compliant error messages
2a0136c

re-fix trailing whitespace for make tidy
5f9aa81

fixed failing doctests
9a4a81f

GuillaumeGomez reviewed Jul 23, 2016
View reviewed changes

Comment threadsrc/librustc_metadata/diagnostics.rs Outdated

Causes of this error:

```ignore
GuillaumeGomezJul 23, 2016
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be ignore.

Jackson O'Donnell added 4 commits July 23, 2016 09:44

Added@GuillaumeGomezrecommendations
055a228

change to "Erroneous code example"
3f6b5e6

Fixed failing Rust_Compiler_Error_Index_487
cdda2c3

Delete empty line
083b536

jhod0 mentioned this pull request Jul 25, 2016
run-pass tests are failing on travis with "fatal runtime error: failed to initiate panic, error 3" #35011
Closed

Jackson O'Donnell added 2 commits July 30, 2016 01:15

Merge remote-tracking branch 'upstream/master'
0608f31
In order to fix failing tests of rust-lang#35011

Fixed failing doctest for E0463
fd9ebcf

GuillaumeGomez reviewed Jul 31, 2016
View reviewed changes

nikomatsakis closed this Aug 16, 2016

GuillaumeGomez mentioned this pull request Aug 29, 2016
Rustc metadata diagnostics #36102
Merged

Uh oh!

Uh oh!

Conversation

jhod0 commented Jul 22, 2016

Uh oh!

rust-highfive commented Jul 22, 2016

Uh oh!

GuillaumeGomez commented Jul 22, 2016

Uh oh!

GuillaumeGomezJul 22, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 22, 2016

Uh oh!

GuillaumeGomez commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 22, 2016

Uh oh!

jhod0 commented Jul 23, 2016

Uh oh!

GuillaumeGomezJul 23, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezJul 23, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jul 23, 2016

Uh oh!

jhod0 commented Jul 30, 2016

Uh oh!

GuillaumeGomezJul 31, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Jul 31, 2016

Uh oh!

nikomatsakis commented Aug 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants