Fix Travis tests by vadimcn · Pull Request #35014 · rust-lang/rust

vadimcn · 2016-07-24T20:07:53Z

vadimcn · 2016-07-24T20:08:44Z

TimNN · 2016-07-24T22:40:05Z

@vadimcn maybe better use a println! to prevent the double panic (and perhaps add some metadata, ie. the value of version, should that check fail, not sure which of the parameters are relevant)?

Also you could change this line in compile test to a println! as well to hopefully know exactly which test is failing (as long as compiletest doesn't do stuff in parallel).

vadimcn · 2016-07-24T23:54:28Z

Can't println from panic_ unwind, as it precedes std in the dependency chain. I was counting on panic! printing the line number. In any case, I'm pretty sure it's the second return site. We're probably trying to get a stack trace through some function that llvm has decided is nounwind.

alexcrichton · 2016-07-25T05:24:06Z

@vadimcn FWIW I can reproduce locally inside the docker container (Ubuntu 16.04) and it appears to be the src/test/run-pass/backtrace.rs test failing which in turn causes compiletest to fail as well.

vadimcn · 2016-07-25T07:25:11Z

Mmkay... so we can fix this by reverting to gcc_personality's behavior (i.e. allowing portions of code to be not covered by the unwind table).

alexcrichton · 2016-07-25T15:57:20Z

@vadimcn looks like tests passed (yay!), wanna merge this after cleaning up a bit?

vadimcn · 2016-07-25T16:42:25Z

Sure. Though this may mask bugs like this one.
r?

alexcrichton · 2016-07-25T16:58:13Z

Ah ok, maybe once we drop support for LLVM 3.7 we can try removing this clause?

@bors: r+ 5fbcf08

alexcrichton · 2016-07-25T16:58:20Z

@bors: p=1

(fixing travis)

bors · 2016-07-25T20:17:45Z

⌛ Testing commit 5fbcf08 with merge d489cae...

bors · 2016-07-25T20:51:36Z

💔 Test failed - auto-linux-64-debug-opt

alexcrichton · 2016-07-25T20:58:27Z

@bors: retry

good ol network failures

On Mon, Jul 25, 2016 at 1:51 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3224
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DDh8zLfB6Arly5ik3myXdREtoHLks5qZSHbgaJpZM4JTp79
.

bors · 2016-07-25T21:02:21Z

⌛ Testing commit 5fbcf08 with merge d1b9c92...

bors · 2016-07-25T21:12:02Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

steveklabnik · 2016-07-25T21:16:59Z

@bors: retry force

bors · 2016-07-25T21:23:00Z

⌛ Testing commit 5fbcf08 with merge db3db70...

bors · 2016-07-25T21:27:02Z

💔 Test failed - auto-win-gnu-32-opt

steveklabnik · 2016-07-25T21:37:19Z

welp

alexcrichton · 2016-07-25T22:15:45Z

@bors: retry

On Mon, Jul 25, 2016 at 2:37 PM, Steve Klabnik notifications@github.com
wrote:

welp
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95M2pwTEOASX1M1kgTNz2_P2MQ0P_ks5qZSySgaJpZM4JTp79
.

bors · 2016-07-25T22:21:34Z

⌛ Testing commit 5fbcf08 with merge 9c396d8...

@vadimcn

Fix Travis tests r? @vadimcn

bors · 2016-07-26T09:10:42Z

💥 Test timed out

steveklabnik · 2016-07-26T14:16:47Z

@bors: retry

On Jul 26, 2016, 02:10 -0700, bors notifications@github.com, wrote:

💥 Test timed out
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (#35014 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AABsivIpbeqsClmJHvUhz8bmExIiokhCks5qZc8UgaJpZM4JTp79).

alexcrichton · 2016-07-26T17:26:52Z

@bors: retry force clean

bors · 2016-07-26T17:26:55Z

⌛ Testing commit 5fbcf08 with merge 0aa25b3...

@vadimcn

Fix Travis tests r? @vadimcn

bors · 2016-07-26T19:55:13Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-07-26T19:56:45Z

@bors: retry

std: Ignore tests where threads outlive main #34983

On Tue, Jul 26, 2016 at 12:55 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1981
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#35014 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JaU6LZUVz-hV2ZLXRfrvgJ8ub9Kks5qZmYkgaJpZM4JTp79
.

bors · 2016-07-27T00:07:09Z

⌛ Testing commit 5fbcf08 with merge b541f5f...

@vadimcn

Fix Travis tests r? @vadimcn

bors · 2016-07-27T03:52:22Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing b541f5f to master...

rust-highfive assigned vadimcn Jul 24, 2016

vadimcn force-pushed the travis-test branch from acadb59 to ca07ee3Compare July 25, 2016 07:27

Looser LSDA parsing
5fbcf08

vadimcn force-pushed the travis-test branch from ca07ee3 to 5fbcf08Compare July 25, 2016 16:38

vadimcn changed the title ~~Travis test - do not merge~~Fix Travis testsJul 25, 2016

vadimcn assigned alexcrichton and unassigned vadimcn Jul 25, 2016

bors added a commit that referenced this pull request Jul 25, 2016
Auto merge of#35014- vadimcn:travis-test, r=alexcrichton
9c396d8
Fix Travis tests r? @vadimcn

bors added a commit that referenced this pull request Jul 26, 2016
Auto merge of#35014- vadimcn:travis-test, r=alexcrichton
0aa25b3
Fix Travis tests r? @vadimcn

vadimcn mentioned this pull request Jul 26, 2016
Rollup of 13 pull requests #35036
Closed

bors added a commit that referenced this pull request Jul 27, 2016
Auto merge of#35014- vadimcn:travis-test, r=alexcrichton
b541f5f
Fix Travis tests r? @vadimcn

bors merged commit 5fbcf08 into rust-lang:masterJul 27, 2016

TimNN mentioned this pull request Jul 28, 2016
Fix build of compiler-rt on FreeBSD #35004
Merged

alexcrichton mentioned this pull request Jul 28, 2016
Refactored code to access TLS only in case of panic (II) #34866
Merged

Uh oh!

Uh oh!

Conversation

vadimcn commented Jul 24, 2016

Uh oh!

vadimcn commented Jul 24, 2016

Uh oh!

TimNN commented Jul 24, 2016

Uh oh!

vadimcn commented Jul 24, 2016 via email

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

vadimcn commented Jul 25, 2016

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

vadimcn commented Jul 25, 2016

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

steveklabnik commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

steveklabnik commented Jul 25, 2016

Uh oh!

alexcrichton commented Jul 25, 2016

Uh oh!

bors commented Jul 25, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

steveklabnik commented Jul 26, 2016

Uh oh!

alexcrichton commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

bors commented Jul 26, 2016

Uh oh!

alexcrichton commented Jul 26, 2016

Uh oh!

bors commented Jul 27, 2016

Uh oh!

bors commented Jul 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants