Uh oh!
There was an error while loading. Please reload this page.
Escape the unmatched surrogates with lower-case hexadecimal numbers - #35084
Merged
Conversation
rust-highfive
commented
Jul 28, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Jul 28, 2016
Contributor
f? @rust-lang/libs This is a minor breaking change, but similar to other recent |
alexcrichton
commented
Jul 28, 2016
Member
Seems reasonable to me, especially if it brings it in line with other escapes we do |
bors
commented
Jul 28, 2016
Collaborator
☔ The latest upstream changes (presumably #34485) made this pull request unmergeable. Please resolve the merge conflicts. |
It's done the same way for the rest of the codepoint escapes.
tbu-force-pushed
the
pr_lowercase_wtf8_debug
branch
from
July 28, 2016 22:52
382c13f to
bb6c27eComparebrson
commented
Aug 1, 2016
Contributor
@bors r+ |
bors
commented
Aug 1, 2016
Collaborator
📌 Commit bb6c27e has been approved by |
bors
commented
Aug 2, 2016
Collaborator
bors added a commit
that referenced
this pull request
Aug 2, 2016
Escape the unmatched surrogates with lower-case hexadecimal numbers It's done the same way for the rest of the codepoint escapes.
bors
commented
Aug 2, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's done the same way for the rest of the codepoint escapes.