resolve: diagnostics improvement and groundwork for RFC 1560 by jseyfried · Pull Request #35116 · rust-lang/rust

jseyfried · 2016-07-29T17:34:31Z

Fixes#35115, fixes#35135, and lays groundwork for #32213 (cc #35120).
r? @nrc

jseyfried · 2016-07-29T18:03:34Z

bors · 2016-07-30T14:29:24Z

☔ The latest upstream changes (presumably #35127) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2016-08-01T03:46:15Z

I feel dirty just reviewing this code - I really wish we didn't use Deref like this in name resolution. Still the damage is done, I guess this doesn't make things much worse.

nrc · 2016-08-01T04:03:14Z

@bors: r+

bors · 2016-08-01T04:03:15Z

📌 Commit 1fc60db has been approved by nrc

bors · 2016-08-01T05:09:18Z

⌛ Testing commit 1fc60db with merge e7aff48...

bors · 2016-08-01T06:01:04Z

💔 Test failed - auto-win-msvc-64-cargotest

sanxiyn · 2016-08-01T06:29:29Z

cargotest failure is legit. (This PR produced additional unused import warnings in cargo which is denied.)

bors · 2016-08-01T15:58:52Z

☔ The latest upstream changes (presumably #34743) made this pull request unmergeable. Please resolve the merge conflicts.

Remove unused import c.f. rust-lang/rust#35116

…, ..)`.

Improve unused import detection.

…ective)`.

jseyfried · 2016-08-01T19:16:20Z

@bors r=nrc

bors · 2016-08-01T19:16:21Z

📌 Commit bc77bdc has been approved by nrc

sanxiyn · 2016-08-02T04:51:49Z

FYI, you need to explicitly update commit hash in src/tools/cargotest/main.rs.

bors · 2016-08-02T12:18:34Z

⌛ Testing commit bc77bdc with merge 2b24fef...

bors · 2016-08-02T13:12:22Z

💔 Test failed - auto-win-msvc-64-cargotest

jseyfried · 2016-08-03T23:15:26Z

@sanxiyn Thanks -- didn't know that!
I updated the cargo_test hash in the above commit.

@bors r=nrc

bors · 2016-08-03T23:15:28Z

📌 Commit 93ab4c6 has been approved by nrc

bors · 2016-08-04T08:52:21Z

⌛ Testing commit 93ab4c6 with merge 7a331fc...

bors · 2016-08-04T10:01:36Z

💔 Test failed - auto-linux-64-cargotest

jseyfried · 2016-08-05T19:29:14Z

@bors r=nrc

bors · 2016-08-05T19:29:15Z

📌 Commit de5eaab has been approved by nrc

bors · 2016-08-05T21:42:42Z

⌛ Testing commit de5eaab with merge 7bf54f9...

@nrc

… r=nrc resolve: diagnostics improvement and groundwork for RFC 1560 Fixes#35115, fixes#35135, and lays groundwork for #32213 (cc #35120). r? @nrc

bors · 2016-08-06T00:26:45Z

💔 Test failed - auto-linux-64-debug-opt

jseyfried · 2016-08-06T00:51:13Z

@bors retry

bors · 2016-08-06T01:46:23Z

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt...

bors · 2016-08-06T05:11:17Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 7bf54f9 to master...

rust-highfive assigned nrc Jul 29, 2016

jseyfried changed the title ~~resolve: diagnostics improvement and groundwork for item_like_imports~~resolve: diagnostics improvement and groundwork for RFC 1560Jul 29, 2016

jseyfried force-pushed the groundwork_for_new_import_semantics branch 2 times, most recently from 9b5eeae to 6750e63Compare July 29, 2016 19:59

jseyfried force-pushed the groundwork_for_new_import_semantics branch 2 times, most recently from e340634 to 1fc60dbCompare July 31, 2016 21:59

nrc reviewed Aug 1, 2016
View reviewed changes

jseyfried mentioned this pull request Aug 1, 2016
Remove unused import rust-lang/cargo#2942
Merged

bors added a commit to rust-lang/cargo that referenced this pull request Aug 1, 2016
Auto merge of#2942- jseyfried:remove_unused_import, r=alexcrichton
9ef9bd7
Remove unused import c.f. rust-lang/rust#35116

jseyfried added 8 commits August 1, 2016 19:06

Implement Deref for ImportResolver to Resolver.
79e82b5

Refactor away resolution.report_conflicts().
5868e78

Refactor away resolution.try_define().
096c3ed

Refactor module.try_define_child(..) -> `resolver.try_define(module…
b107a4e
…, ..)`.

Clean up resolver.record_use().
07c706b

Improve diagnostics for pattern bindings that illegally shadow items.
6372a6d
Improve unused import detection.

nit: rename module_ -> module
0db8ca6

Refactor directive.import(binding) -> `resolver.import(binding, dir…
a18fc76
…ective)`.

jseyfried force-pushed the groundwork_for_new_import_semantics branch from 1fc60db to bc77bdcCompare August 1, 2016 19:11

Update cargo_test hash.
de5eaab

jseyfried force-pushed the groundwork_for_new_import_semantics branch from 93ab4c6 to de5eaabCompare August 5, 2016 19:28

bors added a commit that referenced this pull request Aug 5, 2016
Auto merge of#35116- jseyfried:groundwork_for_new_import_semantics,…
7bf54f9
… r=nrc resolve: diagnostics improvement and groundwork for RFC 1560 Fixes#35115, fixes#35135, and lays groundwork for #32213 (cc #35120). r? @nrc

bors merged commit de5eaab into rust-lang:masterAug 6, 2016

bors mentioned this pull request Aug 6, 2016
Implement the ! type #35162
Merged

jseyfried deleted the groundwork_for_new_import_semantics branch October 16, 2016 09:30

Uh oh!

Uh oh!

Conversation

jseyfried commented Jul 29, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jseyfried commented Jul 29, 2016

Uh oh!

bors commented Jul 30, 2016

Uh oh!

nrcAug 1, 2016

Choose a reason for hiding this comment

Uh oh!

nrc commented Aug 1, 2016

Uh oh!

bors commented Aug 1, 2016

Uh oh!

bors commented Aug 1, 2016

Uh oh!

bors commented Aug 1, 2016

Uh oh!

sanxiyn commented Aug 1, 2016

Uh oh!

bors commented Aug 1, 2016

Uh oh!

jseyfried commented Aug 1, 2016

Uh oh!

bors commented Aug 1, 2016

Uh oh!

sanxiyn commented Aug 2, 2016

Uh oh!

bors commented Aug 2, 2016

Uh oh!

bors commented Aug 2, 2016

Uh oh!

jseyfried commented Aug 3, 2016

Uh oh!

bors commented Aug 3, 2016

Uh oh!

bors commented Aug 4, 2016

Uh oh!

bors commented Aug 4, 2016

Uh oh!

jseyfried commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

bors commented Aug 5, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

jseyfried commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jseyfried commented Jul 29, 2016•
edited
Loading