Uh oh!
There was an error while loading. Please reload this page.
Support removed LLVM intrinsics by invoking its AutoUpgrade mechanism. - #35261
Merged
Conversation
rust-highfive
commented
Aug 3, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Aug 3, 2016
Contributor
@bors r+ p=1 Giving higher priority since it'd be nice to see this in nightly. |
bors
commented
Aug 3, 2016
Collaborator
📌 Commit 63f0c4d has been approved by |
bors
commented
Aug 3, 2016
Collaborator
bors added a commit
that referenced
this pull request
Aug 3, 2016
Support removed LLVM intrinsics by invoking its AutoUpgrade mechanism. Turns out that LLVM sometimes renames platform intrinsics or replaces them with first-class instructions. For example, signed minimum became `select (icmp SLT, a, b), a, b` where `a` and `b` are vectors. This is blocking the Servo rustup ([relevant failure](http://build.servo.org/builders/windows-dev/builds/226/steps/compile/logs/stdio)), as they're using a few such intrinsics. The fix in this PR is to invoke LLVM's own `AutoUpgrade` mechanism to do the replacements.
Merged
nagisa
commented
Aug 3, 2016
Member
Do we want a tracking issue/TODO for when we drop support for the last LLVM which still supports the call natively? |
bors
commented
Aug 3, 2016
Collaborator
💔 Test failed - auto-linux-64-debug-opt |
eddyb
commented
Aug 3, 2016
ContributorAuthor
@bors retry |
eddyb
commented
Aug 3, 2016
ContributorAuthor
@bors force |
bors
commented
Aug 3, 2016
Collaborator
bors
commented
Aug 4, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that LLVM sometimes renames platform intrinsics or replaces them with first-class instructions.
For example, signed minimum became
select (icmp SLT, a, b), a, bwhereaandbare vectors.This is blocking the Servo rustup (relevant failure), as they're using a few such intrinsics.
The fix in this PR is to invoke LLVM's own
AutoUpgrademechanism to do the replacements.