Uh oh!
There was an error while loading. Please reload this page.
rustc_trans: don't Assert(Overflow(Neg)) when overflow checks are off. - #35300
Merged
Conversation
rust-highfive
commented
Aug 4, 2016
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
eddybforce-pushed
the
mir-neg-overflow
branch
2 times, most recently
from
August 4, 2016 16:57
a47ff4c to
cfa911aComparearielb1
commented
Aug 4, 2016
Contributor
@bors r+ This is a terribly hacky patch to a terribly hacky system, but to fix it we need to modify MIR for generic crates. |
bors
commented
Aug 4, 2016
Collaborator
📌 Commit fbabe61 has been approved by |
eddyb
commented
Aug 4, 2016
ContributorAuthor
@bors p=1 (for Servo) |
bors
commented
Aug 4, 2016
Collaborator
⌛ Testing commit fbabe61 with merge 545a3a9... |
bors added a commit
that referenced
this pull request
Aug 4, 2016
rustc_trans: don't Assert(Overflow(Neg)) when overflow checks are off. Generic functions using `Neg` on primitive types would panic even in release mode, with MIR trans. The solution is a bit hacky, as I'm checking the message, since there's no dedicated `CheckedUnOp`. Blocks Servo rustup ([failure #1](http://build.servo.org/builders/linux-rel/builds/2477/steps/test_3/logs/stdio), [failure #2](http://build.servo.org/builders/mac-rel-css/builds/2364/steps/test/logs/stdio)) - this should be the last hurdle, it affects only one test.
This was referenced Aug 4, 2016
bors
commented
Aug 4, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic functions using
Negon primitive types would panic even in release mode, with MIR trans.The solution is a bit hacky, as I'm checking the message, since there's no dedicated
CheckedUnOp.Blocks Servo rustup (failure #1, failure #2) - this should be the last hurdle, it affects only one test.