Skip to content

Update E0009 to new format - #35744

Merged
bors merged 2 commits into
rust-lang:masterfrom
LionOps:ds/update_E0009
Aug 18, 2016
Merged

Update E0009 to new format#35744
bors merged 2 commits into
rust-lang:masterfrom
LionOps:ds/update_E0009

Conversation

@LionOps

@LionOpsLionOps commented Aug 17, 2016

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Looks good. One thing you'll need to fix before it's accepted is the tidy warnings. You can see them by running:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

@sophiajt

sophiajt commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

Great!

@bors r+ rollup

@bors

bors commented Aug 17, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit d01bfb1 has been approved by jonathandturner

@eddybeddyb mentioned this pull request Aug 17, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this pull request Aug 18, 2016
@eddyb
Rollup merge ofrust-lang#35744- DevShep:ds/update_E0009, r=jonathan…
394c449
…dturner
Update E0009 to new format
Part of rust-lang#35233Fixesrust-lang#35193
r? @jonathandturner
bors added a commit that referenced this pull request Aug 18, 2016
@bors
Auto merge of#35769- eddyb:rollup, r=eddyb
9d6520f
Rollup of 12 pull requests
- Successful merges: #35346, #35734, #35739, #35740, #35742, #35744, #35749, #35750, #35751, #35756, #35766, #35768
- Failed merges:
@bors
bors merged commit d01bfb1 into rust-lang:masterAug 18, 2016
@LionOps
LionOps deleted the ds/update_E0009 branch August 18, 2016 17:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LionOps@rust-highfive@sophiajt@bors