modify fds-are-cloexec test to open a file that exists by durka · Pull Request #35885 · rust-lang/rust

durka · 2016-08-21T23:51:40Z

Fixes#35753.

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

r? @nagisa

Fixesrust-lang#35753.

retep998 · 2016-08-22T00:53:07Z

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

I'd argue it is not.

durka · 2016-08-22T00:55:08Z

Maybe the test should create a temporary file, close it, and then open it again?

nagisa · 2016-08-22T13:56:14Z

Is it a valid assumption that the current directory is always the root of the repo when the tests are run?

If such an assumption was “good enough” for the version opening Makefile, I feel it is good enough for the new version as well. You could also use any of the non-autogenerated files from project root, like LICENSE-*.

eddyb · 2016-08-23T17:05:59Z

@bors r=nagisa

bors · 2016-08-23T17:06:00Z

📌 Commit b40754f has been approved by nagisa

@nagisa

modify fds-are-cloexec test to open a file that exists Fixesrust-lang#35753. Is it a valid assumption that the current directory is always the root of the repo when the tests are run? r? @nagisa

@nagisa

modify fds-are-cloexec test to open a file that exists Fixesrust-lang#35753. Is it a valid assumption that the current directory is always the root of the repo when the tests are run? r? @nagisa

@nagisa

modify fds-are-cloexec test to open a file that exists Fixesrust-lang#35753. Is it a valid assumption that the current directory is always the root of the repo when the tests are run? r? @nagisa

Rollup of 6 pull requests - Successful merges: #35238, #35867, #35885, #35916, #35947, #35955 - Failed merges:

Manishearth · 2016-08-25T11:35:27Z


failures:
---- [run-pass] run-pass/fds-are-cloexec.rs stdout ----
error: test run failed!
status: exit code: 101
command: x86_64-apple-darwin/test/run-pass/fds-are-cloexec.stage2-x86_64-apple-darwin stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', ../src/libcore/result.rs:789
note: Run with `RUST_BACKTRACE=1` for a backtrace.
------------------------------------------
thread '[run-pass] run-pass/fds-are-cloexec.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/tools/compiletest/src/runtest.rs:2350
note: Run with `RUST_BACKTRACE=1` for a backtrace.

https://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/10287/steps/test/logs/stdio

Rollup of 6 pull requests - Successful merges: #35238, #35867, #35885, #35916, #35947, #35955 - Failed merges:

durka · 2016-08-25T13:53:02Z

I guess... it's not a valid assumption? Is that a non-rustbuild builder?

On Aug 25, 2016 07:36, "Manish Goregaokar" notifications@github.com wrote:

failures:
---- [run-pass] run-pass/fds-are-cloexec.rs stdout ----
error: test run failed!
status: exit code: 101
command: x86_64-apple-darwin/test/run-pass/fds-are-cloexec.stage2-x86_64-apple-darwin
stdout:
stderr:
thread 'main' panicked at 'called Result::unwrap() on an Err value: Error { repr: Os { code: 2, message: "No such file or directory" } }', ../src/libcore/result.rs:789
note: Run with RUST_BACKTRACE=1 for a backtrace.
thread '[run-pass] run-pass/fds-are-cloexec.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/tools/compiletest/src/runtest.rs:2350
note: Run with RUST_BACKTRACE=1 for a backtrace.
https://buildbot.rust-lang.org/builders/auto-mac-64-opt/
builds/10287/steps/test/logs/stdio
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35885 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC3n76SLVGLkXaQvi8Do_eQMg9FltSZks5qjX4ggaJpZM4JpbCD
.

nagisa · 2016-08-25T14:23:06Z

Thats make. It should operate The same way since there can only ever be one
Makefile in the source tree, in root (since LLVM should not be using
those). The fact that the command is a relative path to the built
executable from the build root, also demonstrates a similar thing.

Anyhow, if a path to the test does not work, then in order to avoid writing
code to create temp file converting the test to a run-make test could be
done.

On Aug 25, 2016 4:53 PM, "Alex Burka" notifications@github.com wrote:

I guess... it's not a valid assumption? Is that a non-rustbuild builder?
On Aug 25, 2016 07:36, "Manish Goregaokar" notifications@github.com
wrote:
failures:
---- [run-pass] run-pass/fds-are-cloexec.rs stdout ----
error: test run failed!
status: exit code: 101
command: x86_64-apple-darwin/test/run-pass/fds-are-cloexec.stage2-
x86_64-apple-darwin
stdout:
stderr:
thread 'main' panicked at 'called Result::unwrap() on an Err value:
Error { repr: Os { code: 2, message: "No such file or directory" } }',
../src/libcore/result.rs:789
note: Run with RUST_BACKTRACE=1 for a backtrace.
thread '[run-pass] run-pass/fds-are-cloexec.rs' panicked at 'explicit
panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-
opt/build/src/tools/compiletest/src/runtest.rs:2350
note: Run with RUST_BACKTRACE=1 for a backtrace.
https://buildbot.rust-lang.org/builders/auto-mac-64-opt/
builds/10287/steps/test/logs/stdio
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#35885 (comment),
or mute
the thread
<https://github.com/notifications/unsubscribe-
auth/AAC3n76SLVGLkXaQvi8Do_eQMg9FltSZks5qjX4ggaJpZM4JpbCD>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35885 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApc0lKVSeCYp3C4eDVuzD1i9UUF0ictks5qjZ5fgaJpZM4JpbCD
.

arielb1 · 2016-08-25T16:21:18Z

This will break out-of-tree builds.

durka · 2016-08-25T16:30:12Z

@arielb1 I guess they didn't work before either.

durka · 2016-08-25T16:31:15Z

The test already doesn't run on Windows, how about opening /dev/null?

arielb1 · 2016-08-25T16:33:03Z

@durka

Out-of-tree builds did work before. I was using them all the time.

I imagine you could open file!().

durka · 2016-08-25T16:34:38Z

Well, it was assuming that the Makefile was in the current directory. I
don't see how the builder failed so I could be missing something glaringly
obvious still.

On Thu, Aug 25, 2016 at 12:33 PM, arielb1 notifications@github.com wrote:

@durka https://github.com/durka
Out-of-tree builds did work before. I was using them all the time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35885 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC3nzNPR6VnwdgoGg5z92C83rZwfXcYks5qjcPjgaJpZM4JpbCD
.

arielb1 · 2016-08-25T16:36:03Z

@durka

The way you do an out-of-tree build is

$ mkdir out-of-tree
$ cd out-of-tree
$ PATH_TO_RUST_ROOT/configure FLAGS
$ make

That way, you end up with a Makefile in your builddir.

arielb1 · 2016-08-25T16:36:37Z

You can do File::open(file!()).unwrap() for maximum robustness.

durka · 2016-08-25T16:38:37Z

Let's try that.

arielb1 · 2016-08-25T17:19:28Z

@bors r+

I don't want to rollup this

bors · 2016-08-25T17:19:29Z

📌 Commit b2cd3e5 has been approved by arielb1

bors · 2016-08-25T22:44:23Z

⌛ Testing commit b2cd3e5 with merge e07dd59...

@nagisa

modify fds-are-cloexec test to open a file that exists Fixes#35753. Is it a valid assumption that the current directory is always the root of the repo when the tests are run? r? @nagisa

bors · 2016-08-26T01:36:30Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: arielb1
Pushing e07dd59 to master...

modify fds-are-cloexec test to open a file that exists
b40754f
Fixesrust-lang#35753.

eddyb mentioned this pull request Aug 23, 2016
Rollup of 15 pull requests #35944
Closed

eddyb mentioned this pull request Aug 23, 2016
Rollup of 13 pull requests #35945
Closed

Manishearth mentioned this pull request Aug 25, 2016
Rollup of 6 pull requests #35979
Merged

bors added a commit that referenced this pull request Aug 25, 2016
Auto merge of#35979- Manishearth:rollup, r=Manishearth
05fb797
Rollup of 6 pull requests - Successful merges: #35238, #35867, #35885, #35916, #35947, #35955 - Failed merges:

bors added a commit that referenced this pull request Aug 25, 2016
Auto merge of#35979- Manishearth:rollup, r=Manishearth
17a2be8
Rollup of 6 pull requests - Successful merges: #35238, #35867, #35885, #35916, #35947, #35955 - Failed merges:

use file!() even though it shouldn't be necessary
b2cd3e5

bors merged commit b2cd3e5 into rust-lang:masterAug 26, 2016

Uh oh!

Uh oh!

Conversation

durka commented Aug 21, 2016

Uh oh!

retep998 commented Aug 22, 2016

Uh oh!

durka commented Aug 22, 2016

Uh oh!

nagisa commented Aug 22, 2016

Uh oh!

eddyb commented Aug 23, 2016

Uh oh!

bors commented Aug 23, 2016

Uh oh!

Manishearth commented Aug 25, 2016

Uh oh!

durka commented Aug 25, 2016

stdout:

stderr:

Uh oh!

nagisa commented Aug 25, 2016

stdout:

stderr:

Uh oh!

arielb1 commented Aug 25, 2016

Uh oh!

durka commented Aug 25, 2016

Uh oh!

durka commented Aug 25, 2016

Uh oh!

arielb1 commented Aug 25, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

durka commented Aug 25, 2016

Uh oh!

arielb1 commented Aug 25, 2016

Uh oh!

arielb1 commented Aug 25, 2016

Uh oh!

durka commented Aug 25, 2016

Uh oh!

arielb1 commented Aug 25, 2016

Uh oh!

bors commented Aug 25, 2016

Uh oh!

bors commented Aug 25, 2016

Uh oh!

bors commented Aug 26, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

arielb1 commented Aug 25, 2016•
edited
Loading