Uh oh!
There was an error while loading. Please reload this page.
fix issue #3535 and add colon between mode and type when dumping function - #3595
Closed
Vincent-Belliard wants to merge 1 commit into
Closed
fix issue #3535 and add colon between mode and type when dumping function#3595Vincent-Belliard wants to merge 1 commit into
Vincent-Belliard wants to merge 1 commit into
Conversation
…ping funcion prototype
nikomatsakis
commented
Sep 26, 2012
Contributor
Thanks! |
RalfJung pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 8, 2024
Fixesrust-lang#3595 by using -fvisibility=hidden and the visibility attribute supported by both gcc and clang rather than the previous gcc-only mechanism for symbol hiding. Also brings over cfg changes from rust-lang#3594 which enable native-lib functionality on all unixes.
RalfJung pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 8, 2024
Enable native libraries on macOS Fixesrust-lang#3595 by using `-fvisibility=hidden` and the visibility attribute supported by both gcc and clang rather than the previous gcc-only mechanism for symbol hiding. Also brings over cfg changes from rust-lang#3594 which enable native-lib functionality on all unixes. Thanks for taking a look, feedback very welcome! cc `@RalfJung`
shrirambalaji pushed a commit
to shrirambalaji/rust
that referenced
this pull request
Oct 6, 2024
Fixesrust-lang#3595 by using -fvisibility=hidden and the visibility attribute supported by both gcc and clang rather than the previous gcc-only mechanism for symbol hiding. Also brings over cfg changes from rust-lang#3594 which enable native-lib functionality on all unixes.
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
3595: Fix completion of trait items r=matklad a=flodiebold Trait items should be public by default. Co-authored-by: Florian Diebold <flodiebold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, an unnamed argument "&int" is parsed "x: int" and not "&x: int" anymore.
When dumping functions prototypes, a colon is added between mode and type.
will be dumped:
The ambiguity between "&x: int" and "x: &int" is removed