Replace try! with ?. by ahmedcharles · Pull Request #36041 · rust-lang/rust

ahmedcharles · 2016-08-27T14:54:50Z

No description provided.

rust-highfive · 2016-08-27T14:55:02Z

(rust_highfive has picked a reviewer for you, use r? to override)

nrc · 2016-08-28T20:33:37Z

lgtm, but just checking with @rust-lang/compiler that they approve

eddyb · 2016-08-28T20:36:25Z

cc @jonathandturner Does this change anything libsyntax uses or might use?
cc @erickt @dtolnay Making sure syntex doesn't get blocked.

nrc · 2016-08-28T20:37:38Z

This is all internal stuff, linbsyntax is touched in #36037

eddyb · 2016-08-28T20:38:50Z

@nrc I was asking mostly because of a potential move of libsyntax to the error code system used in rustc.

ahmedcharles · 2016-08-28T22:19:39Z

I can move changes (if there are any) that would impact syntex to #36037, easily enough and then get this merged.

dtolnay · 2016-08-28T22:22:06Z

None of these affect syntex.

nrc · 2016-08-29T19:57:09Z

@bors: r+

bors · 2016-08-29T19:57:10Z

📌 Commit 26296c4 has been approved by nrc

nikomatsakis · 2016-08-31T11:08:03Z

👍

bors · 2016-09-01T00:48:01Z

☔ The latest upstream changes (presumably #35718) made this pull request unmergeable. Please resolve the merge conflicts.

ahmedcharles · 2016-09-02T08:58:24Z

I assume this needs to be approved again @nrc?

bors · 2016-09-03T04:10:11Z

☔ The latest upstream changes (presumably #36227) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · 2016-09-05T02:11:17Z

@ahmedcharles yes, and unfortunately it needs another rebase now. When you push new commits, it is a good idea to ping the reviewer in a comment since GitHub does not send notifications about new commits (thus why I missed this).

dtolnay · 2016-09-05T02:32:37Z

@nrc

GitHub does not send notifications about new commits (thus why I missed this).

It does if you check the "Pull Request pushes" box at https://github.com/settings/notifications:

sophiajt · 2016-09-05T02:41:25Z

@dtolnay - if we checked that, for the amount of PRs we review, we'd likely swamp our inbox and still not see it, sadly

ahmedcharles · 2016-09-09T12:50:34Z

@nrc Probably ready for another try.

nrc · 2016-09-09T18:51:35Z

@bors: r+

bors · 2016-09-09T18:51:36Z

📌 Commit a51dc66 has been approved by nrc

bors · 2016-09-09T19:40:21Z

⌛ Testing commit a51dc66 with merge 97d8c0c...

bors · 2016-09-09T21:04:30Z

💔 Test failed - auto-win-msvc-64-cargotest

alexcrichton · 2016-09-09T21:55:41Z

@bors: retry

On Fri, Sep 9, 2016 at 2:04 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1774
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36041 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95KX4xXyVGHZWsOyAUhE62f2G0Uz9ks5qocnhgaJpZM4JutjV
.

bors · 2016-09-09T22:27:50Z

⚡ Previous build results for auto-linux-cross-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild...

bors · 2016-09-10T00:14:44Z

💔 Test failed - auto-win-msvc-64-cargotest

ahmedcharles · 2016-09-10T00:40:22Z

Seems like an intermittent failure @alexcrichton @nrc ?

TimNN · 2016-09-10T09:45:05Z

This file does not look like it's actually part of this PR.

ahmedcharles · 2016-09-11T23:04:54Z

The merge conflict issue is fixed. @nrc.

nrc · 2016-09-13T20:44:34Z

@bors: r+

bors · 2016-09-13T20:44:35Z

📌 Commit 694d601 has been approved by nrc

bors · 2016-09-14T01:32:17Z

⌛ Testing commit 694d601 with merge 389abeb...

bors · 2016-09-14T01:43:15Z

💔 Test failed - auto-win-msvc-64-opt-rustbuild

alexcrichton · 2016-09-14T05:41:33Z

@bors: retry

On Tue, Sep 13, 2016 at 6:43 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2482
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36041 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95BZszGUfH0VDa7urOsQCCOQdy3Tdks5qp1E2gaJpZM4JutjV
.

Replace try! with ?.

bors · 2016-09-14T05:41:35Z

⌛ Testing commit 694d601 with merge 739d571...

bors · 2016-09-14T10:29:03Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 739d571 to master...

rust-highfive assigned nrc Aug 27, 2016

TimNN reviewed Sep 10, 2016
View reviewed changes

Comment threadsrc/librustc_incremental/persist/util.rs Outdated
TimNNSep 10, 2016
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not look like it's actually part of this PR.

ahmedcharles added 2 commits September 11, 2016 16:00

Use question_mark feature in linkchecker.
f1c6cad

Use question_mark feature in compiletest.
f0a414e

ahmedcharles added 11 commits September 11, 2016 16:00

Fix typo in bootstrap/lib.rs.
6d88ab5

Use question_mark feature in libcore.
bfd123d

Use question_mark feature in librustc_errors.
8391760

Use question_mark feature in librustc_incremental.
8a9e52a

Use question_mark feature in librustc_mir.
e10e0bc

Use question_mark feature in librustc.
14d3937

Use question_mark feature in libserialize.
d73e374

Use question_mark feature in libstd.
637f149

Use question_mark feature in librustc_back.
0dbf77e

Use question_mark feature in librustc_const_eval.
509aa23

Use question_mark feature in librustc_metadata.
694d601

bors added a commit that referenced this pull request Sep 14, 2016
Auto merge of#36041- ahmedcharles:try, r=nrc
739d571
Replace try! with ?.

bors merged commit 694d601 into rust-lang:masterSep 14, 2016

ahmedcharles deleted the try branch September 17, 2016 10:12

Uh oh!

Uh oh!

Conversation

ahmedcharles commented Aug 27, 2016

Uh oh!

rust-highfive commented Aug 27, 2016

Uh oh!

nrc commented Aug 28, 2016

Uh oh!

eddyb commented Aug 28, 2016

Uh oh!

nrc commented Aug 28, 2016

Uh oh!

eddyb commented Aug 28, 2016

Uh oh!

ahmedcharles commented Aug 28, 2016

Uh oh!

dtolnay commented Aug 28, 2016

Uh oh!

nrc commented Aug 29, 2016

Uh oh!

bors commented Aug 29, 2016

Uh oh!

nikomatsakis commented Aug 31, 2016

Uh oh!

bors commented Sep 1, 2016

Uh oh!

ahmedcharles commented Sep 2, 2016

Uh oh!

bors commented Sep 3, 2016

Uh oh!

nrc commented Sep 5, 2016

Uh oh!

dtolnay commented Sep 5, 2016

Uh oh!

sophiajt commented Sep 5, 2016

Uh oh!

ahmedcharles commented Sep 9, 2016

Uh oh!

nrc commented Sep 9, 2016

Uh oh!

bors commented Sep 9, 2016

Uh oh!

bors commented Sep 9, 2016

Uh oh!

bors commented Sep 9, 2016

Uh oh!

alexcrichton commented Sep 9, 2016

Uh oh!

bors commented Sep 9, 2016

Uh oh!

bors commented Sep 10, 2016

Uh oh!

ahmedcharles commented Sep 10, 2016

Uh oh!

TimNNSep 10, 2016

Choose a reason for hiding this comment

Uh oh!

ahmedcharles commented Sep 11, 2016

Uh oh!

nrc commented Sep 13, 2016

Uh oh!

bors commented Sep 13, 2016

Uh oh!

bors commented Sep 14, 2016

Uh oh!

bors commented Sep 14, 2016

Uh oh!

alexcrichton commented Sep 14, 2016

Uh oh!

bors commented Sep 14, 2016

Uh oh!

bors commented Sep 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development