Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #36042
Closed
Manishearth wants to merge 20 commits into
Closed
Conversation
Doing otherwise would break traits like `ToString`.
This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples. add feature for inclusive_range_syntax fix incorrectly closed code fences
r? @steveklabnik add links for Box, Rc, and Vec
They're the same thing but it's better to keep the terminology consistent.
r? @steveklabnik add examples that lift `<<` and `>>` to a trivial struct replace `Scalar` structs with struct tuples add `fn main` wrappers to enable Rust Playground "Run" button
The affected API apparently had changed with commit d59accf.
Update E0389 to the new format. rust-lang#35630
…les, r=steveklabnik refactor range examples This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples.
…abnik Improve Path and PathBuf docs r? @steveklabnik
Clarify/fix formatting docs concerning fmt::Result/fmt::Error 1. `fmt::Result` != `io::Result<()>` 2. Formatters should only propagate errors, not return their own. Confusion on reddit: https://www.reddit.com/r/rust/comments/4yorxr/is_implt_tostring_for_t_where_t_display_sized_a/
…klabnik add evocative examples for `Shl` and `Shr` r? @steveklabnik
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
…steveklabnik Updated code sample in chapter on syntax extensions. The affected API apparently had changed with commit d59accf. --- Further more I had to add ```toml [lib] name = "roman_numerals" crate-type = ["dylib"] ``` to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`): [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format Might be worth adding a note about that?
Rename {int,uint} methods to {isize,usize}.
Nonerust-highfive
commented
Aug 27, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
commented
Aug 27, 2016
MemberAuthor
@bors r+ p=10 |
bors
commented
Aug 27, 2016
Collaborator
📌 Commit 90df078 has been approved by |
bors
commented
Aug 27, 2016
Collaborator
⌛ Testing commit 90df078 with merge 7e8ccd7... |
bors
commented
Aug 27, 2016
Collaborator
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
alexcrichton
commented
Aug 29, 2016
Member
Seems old now I think? (closing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShlandShr#35863, add links to interesting items instd::ptrdocumentation #35880, Updated code sample in chapter on syntax extensions. #35962, Rename {int,uint} methods to {isize,usize}. #35977RangeToandRangeToInclusivefails #35771, improve documentation forFn*traits #35810