Uh oh!
There was an error while loading. Please reload this page.
Updated E0527 to new error format - #36121
Conversation
Cobrand
commented
Aug 29, 2016
- ClosesE0527 needs to be updated to new format #36113
rust-highfive
commented
Aug 29, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Cobrand
commented
Aug 30, 2016
@jonathandturner I didn't notice we could pick an assignee when starting a PR ; just for future notice is there an way to change the assignee after a pull request has been opened ? The Travis check is failing but I'm not sure it comes from my code. Also, I didn't have to change any test (they were all working even after the changes), but should I update at least the E0527.rs so it fits exactly the error message ? |
sophiajt
commented
Aug 30, 2016
@Cobrand - you can use the same r? but as a new comment. Like this: |
sophiajt
commented
Aug 30, 2016
Cobrand
commented
Aug 30, 2016
@ashrko619 Sorry it was my bad, I didn't see you had to answer the main thread to solve the issue, I just saw it undone and decided to do a PR. Would you mind passing this to me since I have already a PR done or do you have something ready already ? |
ashrwin
commented
Aug 31, 2016
@Cobrand@jonathandturner No issues. I haven't yet started working on it :) |
sophiajt
commented
Aug 31, 2016
Sounds good. @Cobrand - I'll update this one to point to you |
sophiajt
commented
Aug 31, 2016
Alright, now to review... @Cobrand - looks like it's a good start. The next thing to do is to make sure that the unit tests are updated to test for this new label. You can read how to do this in the Extra Credit section of the blog post. There's a quirk of the unit test system that means you'll need a NOTE before it will test the for the labels. |
sophiajt
commented
Sep 5, 2016
@Cobrand - looks like this one is getting close. When you're ready, squash the 3 commits down to 1 and ping me and I'll review. |
Cobrand
commented
Sep 5, 2016
@jonathandturner it should be fine now. |
sophiajt
commented
Sep 5, 2016
Great. @bors r+ rollup |
bors
commented
Sep 5, 2016
📌 Commit e8c5dc4 has been approved by |
Updated E0527 to new error format * Closesrust-lang#36113
Updated E0527 to new error format * Closesrust-lang#36113