Skip to content

use adt::trans_const when translating constant closures and tuples - #36406

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:constant-padding
Sep 12, 2016
Merged

use adt::trans_const when translating constant closures and tuples#36406
bors merged 1 commit into
rust-lang:masterfrom
arielb1:constant-padding

Conversation

@arielb1

@arielb1arielb1 commented Sep 11, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

The previous way dropped padding on the floor.

Fixes#36401

r? @eddyb

@arielb1arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 11, 2016
@arielb1

arielb1 commented Sep 11, 2016

Copy link
Copy Markdown
ContributorAuthor

beta-nominated since regression.

@eddyb

eddyb commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 12, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f1bd907 has been approved by eddyb

@bors

bors commented Sep 12, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f1bd907 with merge 85592fb...

bors added a commit that referenced this pull request Sep 12, 2016
@bors
Auto merge of#36406- arielb1:constant-padding, r=eddyb
85592fb
use `adt::trans_const` when translating constant closures and tuples
The previous way dropped padding on the floor.
Fixes#36401
r? @eddyb
@bors

bors commented Sep 12, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 85592fb to master...

@bors
bors merged commit f1bd907 into rust-lang:masterSep 12, 2016
@borsbors mentioned this pull request Sep 12, 2016
Merged
@nikomatsakis

nikomatsakis commented Sep 19, 2016

Copy link
Copy Markdown
Contributor

Accepting for beta. Relatively small patch, regression. But I encourage @rust-lang/compiler people to take a look.

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2016
@brsonbrson mentioned this pull request Sep 19, 2016
Merged
@pnkfelixpnkfelix mentioned this pull request Sep 21, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arielb1@eddyb@bors@nikomatsakis@brson