Skip to content

invoke drop glue with a ptr to (data, meta) - #36459

Merged
bors merged 2 commits into
rust-lang:masterfrom
nikomatsakis:issue-35546
Sep 15, 2016
Merged

invoke drop glue with a ptr to (data, meta)#36459
bors merged 2 commits into
rust-lang:masterfrom
nikomatsakis:issue-35546

Conversation

@nikomatsakis

@nikomatsakisnikomatsakis commented Sep 13, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

This is done by creating a little space on the stack. Hokey, but it's the simplest fix I can see, and I am in "kill regressions" mode right now.

Fixes#35546

r? @eddyb

@nikomatsakis
invoke drop glue with a ptr to (data, meta)
b49a26e
This is done by creating a little space on the stack. Hokey, but it's
the simplest fix I can see.
@nikomatsakisnikomatsakis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 13, 2016
@nikomatsakis

nikomatsakis commented Sep 13, 2016

Copy link
Copy Markdown
ContributorAuthor

Nominating for beta: regression. (But it has not yet been r+'d!)

@eddyb

eddyb commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 13, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b49a26e has been approved by eddyb

@nikomatsakis

nikomatsakis commented Sep 13, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Sep 13, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 693676d has been approved by eddyb

@bors

bors commented Sep 14, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 693676d with merge 3e6a5ad...

@bors

bors commented Sep 14, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton

alexcrichton commented Sep 14, 2016

Copy link
Copy Markdown
Member

@bors: retry

On Tue, Sep 13, 2016 at 7:55 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2494

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36459 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95JaRnhShlJ5Gdvr-1o6DfbnU9gALks5qp2IxgaJpZM4J8Hv5
.

@ManishearthManishearth mentioned this pull request Sep 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2016
@Manishearth
Rollup merge ofrust-lang#36459- nikomatsakis:issue-35546, r=eddyb
959f764
invoke drop glue with a ptr to (data, meta)
This is done by creating a little space on the stack. Hokey, but it's the simplest fix I can see, and I am in "kill regressions" mode right now.
Fixesrust-lang#35546
r? @eddyb
bors added a commit that referenced this pull request Sep 15, 2016
@bors
Auto merge of#36491- Manishearth:rollup, r=Manishearth
dc75933
Rollup of 9 pull requests
- Successful merges: #36384, #36405, #36425, #36429, #36438, #36454, #36459, #36461, #36463
- Failed merges: #36444
@bors
bors merged commit 693676d into rust-lang:masterSep 15, 2016
@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2016
@nikomatsakis

nikomatsakis commented Sep 19, 2016

Copy link
Copy Markdown
ContributorAuthor

Accepting for beta. Relatively small patch, fixes regression.

@brsonbrson mentioned this pull request Sep 19, 2016
Merged
@pnkfelix

pnkfelix commented Sep 21, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@nikomatsakis Note for future: Please try to avoid extraneous whitespace/line break changes for PR's that are intended for the outset to be applied to beta. (A reason this PR failed to apply cleanly was two files that had solely comments added and line break /whitespace changes...)

  • (Okay, it had a few other problems too; namely it seems fn get_dataptr migrated from mod expr to mod base over time for some reason.)

@eddyb

eddyb commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

@pnkfelixtrans::expr was removed as part of old trans purging, but a few pieces survived elsewhere.

@pnkfelix

pnkfelix commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

@eddyb ah I suppose that sort of delta is unavoidable then. Ah such tensions from refactoring.

@pnkfelixpnkfelix mentioned this pull request Sep 21, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2016
@nikomatsakis
nikomatsakis deleted the issue-35546 branch April 14, 2017 10:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LLVM assertion failure with moving boxed DST

6 participants

@nikomatsakis@eddyb@bors@alexcrichton@pnkfelix@brson