Uh oh!
There was an error while loading. Please reload this page.
Add changelog for 1.12 - #36609
Merged
Merged
Conversation
rust-highfive
commented
Sep 21, 2016
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
retep998
suggested changes
Sep 21, 2016
WiSaGaN
reviewed
Sep 21, 2016
Contributor
There was a problem hiding this comment.
Missing backtick after second macro_rules
japaric
reviewed
Sep 21, 2016
Contributor
There was a problem hiding this comment.
perhaps should mention that these targets produce statically linked binaries.
brson
commented
Sep 21, 2016
ContributorAuthor
Updated. Thanks for the feedback. |
brson
commented
Sep 21, 2016
ContributorAuthor
I went ahead and ported this to beta as-is. |
arielb1
suggested changes
Sep 22, 2016
Contributor
There was a problem hiding this comment.
That's only for MIR, and no improvement over pre-MIR.
liigo
reviewed
Sep 23, 2016
Member
There was a problem hiding this comment.
I think this should be "inside" instead of "insider"
brson
commented
Sep 27, 2016
ContributorAuthor
Updated. |
alexcrichton
commented
Sep 27, 2016
Member
@bors: r+ |
bors
commented
Sep 27, 2016
Collaborator
📌 Commit a6903e4 has been approved by |
bors
commented
Sep 27, 2016
Collaborator
bors added a commit
that referenced
this pull request
Sep 27, 2016
Add changelog for 1.12 [Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md).
brson
commented
Sep 27, 2016
ContributorAuthor
Now this needs to be backported to the 1.13 beta as well. |
bors
commented
Sep 27, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered.