Implement Debug for DirEntry.

[frewsxcv]

No description provided.

[sfackler]

Thanks!

@bors r+

[bors]

📌 Commit 84b68f3 has been approved by sfackler

[frewsxcv]

Updated. @sfackler can I get another r?

[sfackler]

@bors r+

[bors]

📌 Commit 8b8681e has been approved by sfackler

[sophiajt]

@bors r-

Removing it since it seems like it fails on Windows (tried it during a rollup).

test fs::tests::dir_entry_debug ... FAILED
test fs::tests::dir_entry_methods ... ok
thread '<unnamed>' panicked at 'assertion failed: `(left == right)` (left: `"DirEntry(\"C:\\\\Users\\\\RUSTBU~1\\\\AppData\\\\Local\\\\Temp\\\\rust-3438732025\\\\b\")"`, right: `"DirEntry(\"C:\\Users\\RUSTBU~1\\AppData\\Local\\Temp\\rust-3438732025\\b\")"`)', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\fs.rs:2662
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Happy to run it through again once a fix is ready.

[frewsxcv]

Uh, if anyone has insight why Windows renders path with \\\\, information would be greatly appreciated

[Aatch]

@frewsxcv your debug impl will format the inner string using the Debug format. Whereas your test uses Display.

[frewsxcv]

I think I fixed it. Can I get a re-review?

[sfackler]

@bors r+

[bors]

📌 Commit 6b697a3 has been approved by sfackler

[bors]

⌛ Testing commit 6b697a3 with merge f2c53ea...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: sfackler
Pushing f2c53ea to master...