Skip to content

#36553 specialisation error 520 is misleading - #36652

Merged
bors merged 2 commits into
rust-lang:masterfrom
giannicic:issue-36553
Sep 26, 2016
Merged

#36553 specialisation error 520 is misleading#36652
bors merged 2 commits into
rust-lang:masterfrom
giannicic:issue-36553

Conversation

@giannicic

@giannicicgiannicic commented Sep 22, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

this commit corrects E0520 error text.
See referenced issue for further info

r? @nrc

@giannicic
rust-lang#36553specialisation error 502 is misleading
a35275c
this commit correct E0502 error text.
See referenced issue for further info
@rust-highfive

rust-highfive commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomezGuillaumeGomez changed the title #36553 specialisation error 502 is misleading#36553 specialisation error 520 is misleadingSep 25, 2016
nrc
nrc reviewed Sep 25, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
err.span_label(span, &"parent `impl` is here");
err.note(&format!("to specialize, either the parent `impl` or `{}` \
err.note(&format!("to specialize, `{}` \
in the parent `impl` must be marked `default`",

@nrcnrcSep 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this string could all fit on one line now.

@nrc

nrc commented Sep 25, 2016

Copy link
Copy Markdown
Member

looks good, thanks! r=me with the nit about the string fixed.

@giannicic

giannicic commented Sep 26, 2016

Copy link
Copy Markdown
ContributorAuthor

r=nrc

@nrc

nrc commented Sep 26, 2016

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Sep 26, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 63a5892 has been approved by nrc

@bors

bors commented Sep 26, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 63a5892 with merge 0a0215d...

bors added a commit that referenced this pull request Sep 26, 2016
@bors
Auto merge of#36652- giannicic:issue-36553, r=nrc
0a0215d
this commit corrects E0520 error text.
See referenced issue for further info
r? @nrc
@bors

bors commented Sep 26, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 0a0215d to master...

@bors
bors merged commit 63a5892 into rust-lang:masterSep 26, 2016
@borsbors mentioned this pull request Sep 26, 2016
Merged
@giannicic
giannicic deleted the issue-36553 branch September 27, 2016 15:41
@kyriaskyrias mentioned this pull request Oct 18, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nrcnrcnrc left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giannicic@rust-highfive@nrc@bors