Uh oh!
There was an error while loading. Please reload this page.
[breaking-change] Remove TypedArena::with_capacity - #36657
Conversation
The function is unused by rustc. Also, it doesn't really follow the usual meaning of a `with_capacity` function because the first chunk allocation is now delayed until the first `alloc` call. This change reduces the size of `TypedArena` by one `usize`.
rust-highfive
commented
Sep 22, 2016
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Sep 22, 2016
@bors r+ Thanks! |
bors
commented
Sep 22, 2016
📌 Commit cf50f5f has been approved by |
bors
commented
Sep 23, 2016
⌛ Testing commit cf50f5f with merge d6954e8... |
bors
commented
Sep 23, 2016
💔 Test failed - auto-win-gnu-64-opt |
nnethercote
commented
Sep 24, 2016
@eddyb: run-make\output-type-permutations failed. I don't understand what went wrong. Is it the compile warnings about |
eddyb
commented
Sep 24, 2016
Don't see how it's relevant. @bors retry |
bors
commented
Sep 24, 2016
⌛ Testing commit cf50f5f with merge 7ce16f6... |
bors
commented
Sep 24, 2016
💔 Test failed - auto-mac-64-opt-rustbuild |
nnethercote
commented
Sep 24, 2016
@eddyb: another failure that's not my fault? It's an exception in Python code... |
eddyb
commented
Sep 24, 2016
The bots may be acting up, but it's a weekend so I don't think I have any way of confirming. @bors retry |
bors
commented
Sep 24, 2016
⌛ Testing commit cf50f5f with merge a0843d7... |
[breaking-change] Remove TypedArena::with_capacity This is a follow-up to #36592. The function is unused by rustc. Also, it doesn't really follow the usual meaning of a `with_capacity` function because the first chunk allocation is now delayed until the first `alloc` call. This change reduces the size of `TypedArena` by one `usize`. @eddyb: we discussed this on IRC. Would you like to review it?
This is a follow-up to #36592.
The function is unused by rustc. Also, it doesn't really follow the
usual meaning of a
with_capacityfunction because the first chunkallocation is now delayed until the first
alloccall.This change reduces the size of
TypedArenaby oneusize.@eddyb: we discussed this on IRC. Would you like to review it?